Skip to content

Commit 34ba921

Browse files
committed
docs(service-package): re-anchor the dead tracker citations to the commits that decided them
Stage 10 of the domain:services dead-citation sweep (ruling C+D, form C). Every comment or docblock site under packages/services/service-package/src that cited a tracker number answering 404 now cites the commit in this repository's history that decided what the line describes, and says in its own words what that commit decided. Comments only: each touched file keeps its line count, and no code token moves. Claude-Session: https://claude.ai/code/session_01XY5uCwTjZj7884yYtyur4H Co-authored-by: Claude <noreply@anthropic.com>
1 parent 4dfff17 commit 34ba921

5 files changed

Lines changed: 17 additions & 17 deletions

File tree

‎packages/services/service-package/src/delete-driver-fault.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ describe('[#8275] a throw that DECLARES an envelope is re-thrown, not swallowed'
316316
* an accident the `{code}`-only fakes above cannot see.
317317
*
318318
* ⛔ Not a re-judgement of `declaresHttpAnswer`: its docblock already says a
319-
* declared 5xx is re-thrown too. The reviewer of PR #16650 required the flip
319+
* declared 5xx is re-thrown too. The reviewer of commit 001a83b04 required the flip
320320
* to be pinned, not the predicate to be changed.
321321
*/
322322
describe('[#16019] a raw-statement fault that DECLARES its status is re-thrown, where its undeclared ancestor was swallowed', () => {

‎packages/services/service-package/src/index.ts‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ function declaresHttpAnswer(error: unknown): boolean {
205205
* the SAME row, so the next divergence is a red test rather than prose someone
206206
* has to re-read.
207207
*
208-
* ⚠️ [#10965] It returns `[]` for EVERYTHING else too, and that is the whole
208+
* ⚠️ [commit ab47f6974] It returns `[]` for EVERYTHING else too, and that is the whole
209209
* defect this file's seam guard exists for — see {@link isResultSet}. Flatten
210210
* with this only AFTER the result has been established as an answer.
211211
*/
@@ -220,7 +220,7 @@ function normalizeRows(result: any): any[] {
220220
}
221221

222222
/**
223-
* ── The seam that ACCEPTS a query but never ANSWERS one (#10965) ───────────
223+
* ── The seam that ACCEPTS a query but never ANSWERS one (commit ab47f6974) ──
224224
*
225225
* {@link normalizeRows} flattens the result-set shapes a raw SELECT comes back
226226
* as. A seam can hand back one more thing, and it means something else
@@ -231,8 +231,8 @@ function normalizeRows(result: any): any[] {
231231
* — which is also what a real driver returns for a SELECT that matched nothing.
232232
*
233233
* Both read paths in this service then reported that emptiness as a fact about
234-
* the data, and unlike its two siblings (#10677 / PR #10788 for
235-
* `os migrate duplicates`, #10789 / PR #10964 for `backfillSeedTenancy`) what
234+
* the data, and unlike its two siblings (#10677 / commit 3a7ec2d3b for
235+
* `os migrate duplicates`, commit 38bc74ed1 for `backfillSeedTenancy`) what
236236
* they hand back is a PRODUCT ANSWER a caller acts on:
237237
*
238238
* - `get()` returned `null` ⇒ "this package is not installed".
@@ -283,7 +283,7 @@ function isResultSet(result: unknown): boolean {
283283
}
284284

285285
/**
286-
* [#10965] The caller-facing sentence a read over a non-answering seam gets.
286+
* [commit ab47f6974] The caller-facing sentence a read over a non-answering seam gets.
287287
*
288288
* Like {@link PACKAGE_PUBLISH_DRIVER_FAULT_MESSAGE}, a CONSTANT that
289289
* interpolates nothing: no driver text, no statement, no table name. It says
@@ -301,7 +301,7 @@ export const PACKAGE_SEAM_UNREADABLE_MESSAGE =
301301
const SEAM_UNREADABLE = Symbol.for('objectstack.service-package.seam-unreadable');
302302

303303
/**
304-
* [#10965] The refusal a read raises when the seam did not answer.
304+
* [commit ab47f6974] The refusal a read raises when the seam did not answer.
305305
*
306306
* ADR-0112 envelope: a `status` AND a `code`, both declared, so it leaves by
307307
* the door's shared `errorFromThrown` mapping as the producer's own answer
@@ -324,7 +324,7 @@ function packageSeamUnreadableError(): Error {
324324
}
325325

326326
/**
327-
* [#10965] Is this the seam refusal above?
327+
* [commit ab47f6974] Is this the seam refusal above?
328328
*
329329
* ⛔ Deliberately NOT {@link declaresHttpAnswer}. That predicate asks the much
330330
* broader "did this throw declare an envelope?", and widening the two READ
@@ -448,7 +448,7 @@ export class PackageServicePlugin implements Plugin {
448448
const args = version === 'latest' ? [packageId] : [packageId, version];
449449
const result = await objectql.execute!({ sql, args });
450450

451-
// [#10965] Before reading emptiness as a fact, establish that there
451+
// [commit ab47f6974] Before reading emptiness as a fact, establish that there
452452
// was an answer to read. A seam that did not run the SELECT hands
453453
// back no result set, and `normalizeRows` maps that to `[]` — the
454454
// same value a real driver returns when the package genuinely is not
@@ -473,7 +473,7 @@ export class PackageServicePlugin implements Plugin {
473473
updated_at: row.updated_at,
474474
};
475475
} catch (error) {
476-
// [#10965] The seam refusal is the ONE throw this catch must not
476+
// [commit ab47f6974] The seam refusal is the ONE throw this catch must not
477477
// swallow: swallowing it would restore the exact `null` the refusal
478478
// exists to replace, and the caller would be back to reading "not
479479
// installed" off a query that never ran. Everything else keeps the
@@ -499,7 +499,7 @@ export class PackageServicePlugin implements Plugin {
499499
`,
500500
});
501501

502-
// [#10965] Same separation as `get()`: a seam that never ran this
502+
// [commit ab47f6974] Same separation as `get()`: a seam that never ran this
503503
// SELECT must not be reported as "no packages are installed". An
504504
// answering seam with zero rows still returns `[]` below.
505505
if (!isResultSet(result)) throw packageSeamUnreadableError();
@@ -514,7 +514,7 @@ export class PackageServicePlugin implements Plugin {
514514
updated_at: row.updated_at,
515515
}));
516516
} catch (error) {
517-
// [#10965] As in `get()`: only the seam refusal escapes, because
517+
// [commit ab47f6974] As in `get()`: only the seam refusal escapes, because
518518
// swallowing it would answer "nothing installed" over a driver this
519519
// method never queried.
520520
if (isSeamUnreadable(error)) {
@@ -623,7 +623,7 @@ export class PackageServicePlugin implements Plugin {
623623
}
624624
}
625625
} catch (error) {
626-
// [#10965] The measured consequence of the conflation, and the half that
626+
// [commit ab47f6974] The measured consequence of the conflation, and the half that
627627
// made it invisible. `list()` used to answer `[]` over a seam that never
628628
// ran the SELECT, so this loop iterated zero times and said nothing —
629629
// its only log sits behind `hydrated > 0`. A durable package was then

‎packages/services/service-package/src/mysql2-tuple.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
* ## What the defect did
2424
*
2525
* The tuple is an ARRAY, so it satisfied both the old `Array.isArray(result)`
26-
* branch and `isResultSet` — no false 503, and #10965's guard was never at
26+
* branch and `isResultSet` — no false 503, and commit ab47f6974's guard was never at
2727
* fault. `normalizeRows` simply returned the 2-element tuple, so:
2828
*
2929
* - `get()` read `rows[0]` — the row ARRAY, not a row. `row.manifest` was
@@ -193,7 +193,7 @@ describe('#11062 the tuple test cannot swallow a bare row array', () => {
193193

194194
describe('#11062 empty results remain "no rows", never a refusal', () => {
195195
/**
196-
* The half that stops this being a rename (#10965's leg, re-asserted for the
196+
* The half that stops this being a rename (commit ab47f6974's leg, re-asserted for the
197197
* shape this card adds): an empty result set in ANY spelling is still a
198198
* result set, so it answers "not installed" / "nothing installed" rather than
199199
* raising the seam refusal.

‎packages/services/service-package/src/null-seam.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license.
22

33
/**
4-
* #10965 — `get()` / `list()` answered over a driver they never queried.
4+
* The card behind commit ab47f6974 — `get()` / `list()` answered over a driver they never queried.
55
*
66
* ## What was measured before the fix
77
*

‎packages/services/service-package/src/publish-driver-fault.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ describe('[#8131] the caller-facing sentence interpolates nothing', () => {
354354
* an accident the `{code}`-only fakes above cannot see.
355355
*
356356
* ⛔ Not a re-judgement of `declaresHttpAnswer`: its docblock already says a
357-
* declared 5xx is re-thrown too. The reviewer of PR #16650 required the flip
357+
* declared 5xx is re-thrown too. The reviewer of commit 001a83b04 required the flip
358358
* to be pinned, not the predicate to be changed.
359359
*/
360360
describe('[#16019] a raw-statement fault that DECLARES its status is re-thrown, where its undeclared ancestor was swallowed', () => {

0 commit comments

Comments
 (0)