You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 4d31b13
Browse filesBrowse the repository at this point in the historyBrowse files
fix(release): the image backfill skips a version whose publishing run has not finished building its image
The audit step asks the in-flight reader once, before either backfill,
and gates `image-missing` on its `docker` verdict the way it gates
`releases-missing` on the publish job's: a notice while the publishing
run's docker job is not yet created, queued or running; a warning, and
no request, when the read is unreadable or cannot be asked; the existing
request otherwise. Battery 12 of release-verify-npm's self-test pins the
four triage pins plus the not-yet-created case at the audit's own text.
Claude-Session: https://claude.ai/code/session_01T9u38rswFp5Rw8DswRUReJ
Co-authored-by: Claude <noreply@anthropic.com>
echo "::warning::${version}'s GitHub Releases or ADR-0087 D4 asset are incomplete, and whether its publish is still in flight could not be asked (reason above). Nothing is backfilled off a guess; the next landing reads again."
1091
1102
elif [ "$(jq -r '.state' <<<"$flight")" != 'clear' ]; then
1092
-
jq -c . <<<"$flight"
1093
1103
if [ "$(jq -r '.reason' <<<"$flight")" = 'publish-in-flight' ]; then
1094
1104
echo "::notice::${version}'s GitHub Releases or ADR-0087 D4 asset are incomplete, but its publish is still in flight ($(jq -r '.detail' <<<"$flight")). That run creates them; nothing is backfilled beside it. A landing after it finishes backfills whatever it did not."
1095
1105
else
1096
1106
echo "::warning::${version}'s GitHub Releases or ADR-0087 D4 asset are incomplete, and whether its publish is still in flight could not be read ($(jq -r '.detail' <<<"$flight")). Nothing is backfilled off a guess; the next landing reads again."
1097
1107
fi
1098
1108
else
1099
-
jq -c . <<<"$flight"
1100
1109
echo "::warning::${version} is on npm but its GitHub Releases or the ADR-0087 D4 asset are incomplete (#4900) — backfilling."
1101
1110
echo "releases-missing=true" >> "$GITHUB_OUTPUT"
1102
1111
fi
1103
1112
if [ "$image_ok" = true ]; then
1104
1113
echo "ghcr: image for $version is present."
1114
+
elif [ "$flight_asked" != true ]; then
1115
+
echo "::warning::No ghcr image for ${version} (or the registry could not be probed), and whether its publishing run is still building it could not be asked (reason above). No Docker job is requested off a guess; the next landing reads again."
1116
+
elif [ "$(jq -r '.docker.state' <<<"$flight")" != 'clear' ]; then
1117
+
if [ "$(jq -r '.docker.reason' <<<"$flight")" = 'docker-in-flight' ]; then
1118
+
echo "::notice::No ghcr image for ${version} yet, but its publishing run has not finished building it ($(jq -r '.docker.detail' <<<"$flight")). That run pushes the image; no Docker job is requested beside it. A landing after it finishes requests one if the image is still missing."
1119
+
else
1120
+
echo "::warning::No ghcr image for ${version} (or the registry could not be probed), and whether its publishing run is still building it could not be read ($(jq -r '.docker.detail' <<<"$flight")). No Docker job is requested off a guess; the next landing reads again."
1121
+
fi
1105
1122
else
1106
1123
echo "::warning::No ghcr image for $version (or the registry could not be probed) — requesting the Docker job."
t('a publish of ANOTHER version in flight does not hold this one back: the Releases are backfilled',other.outputs['releases-missing']==='true',said(other));
1853
+
t('...and the image is requested',other.outputs['image-missing']==='true',said(other));
0 commit comments