Repository navigation
Commit 4d8617e
committed
docs(spec): the ResumeFailureReport docblock stops inviting the parse that strips its code
`ResumeFailureReport.code` is required, and the type's own docblock invited a
caller to parse the member with `ResumeFailureDetailsSchema`. That schema
declares the three shared members and not `code`, and it is a plain non-strict
`z.object`, so the invited path strips the code silently: the parse succeeds,
raises no `unrecognized_keys` issue and logs nothing, and the caller is left
holding a failure report with no failure class — the one member the same
docblock calls indispensable.
Prose only. `ResumeFailureDetailsSchema` is correct where it is used (the
resume door's `400 FLOW_FAILED` details, where the code rides on the error
envelope beside it), and declaring `code` on it would widen a published accept
surface and break the "declared ONCE" identity the contract pin asserts.
Both halves are pinned in `contracts/resume-failure-report.pin.test.ts`: the
silence of the strip, and the docblock carrying the warning instead of the
invitation.
Claude-Session: https://claude.ai/code/session_01JbZnqu8bt6YqfJsr9vaFb3
Co-authored-by: Claude <noreply@anthropic.com>1 parent 5ed7ad9 commit 4d8617e
3 files changed
Lines changed: 68 additions & 6 deletions
File tree
- .changeset
- packages/spec/src/contracts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
571 | 571 | | |
572 | 572 | | |
573 | 573 | | |
574 | | - | |
575 | | - | |
576 | | - | |
577 | | - | |
578 | | - | |
579 | | - | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
580 | 593 | | |
581 | 594 | | |
582 | 595 | | |
| |||
Lines changed: 36 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
128 | 137 | | |
129 | 138 | | |
130 | 139 | | |
| |||
136 | 145 | | |
137 | 146 | | |
138 | 147 | | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
139 | 175 | | |
140 | 176 | | |
141 | 177 | | |
| |||
0 commit comments