Skip to content

Commit 4dda1fd

Browse files
committed
docs(lint): cut three false runtime and control claims from the walk comments
The preset test header claimed its dataSource.filter lit control in every block below; only the first block carries one. The token test comment called an unknown token a silent literal; the engine's token resolver throws FILTER_TOKEN_UNKNOWN on it. The FILTER_KEYS docblock said an ordering preset in either carrier was refused at query time; the engine's temporal door refuses only on a date, datetime or time field. Each clause is cut; comments only, no code moves. Claude-Session: https://claude.ai/code/session_01Sfe5YjBLwB9J3y8fvm2xq1 Co-authored-by: Claude <noreply@anthropic.com>
1 parent bf2d6dc commit 4dda1fd

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

‎packages/lint/src/filter-walk.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ type AnyRec = Record<string, unknown>;
7171
* `filter`) and a lookup field's picker filter (`lookupFilters`, lowered by the
7272
* console to a Mongo `$filter` on the REFERENCED object). Both values reach
7373
* the engine's `where` verbatim. Their schemas carry no preset check, so
74-
* before this entry an ordering preset in either parsed green, linted green,
75-
* and was refused only at query time. The binding half — which object a condition on each carrier
74+
* before this entry an ordering preset in either parsed green, linted green.
75+
* The binding half — which object a condition on each carrier
7676
* addresses — is `validate-preset-comparands.ts`'s, not this walk's.
7777
*/
7878
export const FILTER_KEYS: ReadonlySet<string> = new Set([

‎packages/lint/src/validate-filter-tokens.test.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,7 @@ describe('validateFilterTokens', () => {
182182

183183
// [#19791] A list page's `interfaceConfig.filterBy` and a lookup field's
184184
// `lookupFilters` reach the engine's `where` verbatim, where the same two
185-
// placeholder vocabularies resolve — so an unknown token there is the same
186-
// silent literal it is in a view's `filter`, and the known ones are fine.
185+
// placeholder vocabularies resolve.
187186
it('reaches a page filterBy and a lookup field lookupFilters', () => {
188187
const findings = validateFilterTokens({
189188
objects: [{

‎packages/lint/src/validate-preset-comparands.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -680,7 +680,7 @@ describe('validatePresetComparands — arm 2, the FIELD-TYPED equality / members
680680
// carries a preset check. Before `FILTER_KEYS` named them, the card's rule
681681
// `{ field: 'close_date', operator: 'gt', value: 'last_30_days' }` parsed
682682
// green AND linted green on both, while the identical rule on a component
683-
// `dataSource.filter` was refused — the lit control every block below keeps.
683+
// `dataSource.filter` was refused.
684684
describe('validatePresetComparands — page filterBy and lookup-field lookupFilters (#19791)', () => {
685685
const card = { field: 'close_date', operator: 'gt', value: 'last_30_days' };
686686
// `close_date` is a DATE on `crm_deal` and a SELECT on `crm_region`, whose

0 commit comments

Comments
 (0)