You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 63d1992
Browse filesBrowse the repository at this point in the historyBrowse files
fix(cli): the #12525 read-back's anti-vacuity pins read CODE, and bind the argument rather than the argument list
`serve-port-readback.e2e.test.ts` runs only in the nightly `e2e` tier, so no
pull request can redden it. Two source-text pins in its ANTI-VACUITY describe
read the raw file, and both went red on `main` for reasons that were never
about the product:
- the print-order pin did `indexOf` over the whole of `src/utils/format.ts`.
#17892 added a docblock quoting `Press Ctrl+C to stop` 281 lines above the
`console.error` that prints it, so the raw read put the tail at offset
38075 and the `API:` row at 47343 and the assertion reported a print order
that had never changed. In code position the two are 47343 and 53551, i.e.
line 984 before line 1081, exactly as the pin claims.
- the banner pin held the byte-exact `resolveAuthBaseUrl(boundPort)` call.
#17725 added a `boundProtocol` argument. The per-PR sibling
`src/commands/serve-bound-port-publication.test.ts` was updated in that
same commit; this nightly-only copy could not be, and had no way to say so
until the next sweep.
Both pins now read through `scripts/js-comment-mask.mjs`, the tree's one
answer to code-versus-prose, which also closes the other direction: a comment
naming a pinned spelling can no longer satisfy the pin with no code behind it.
The mask carries its own anti-vacuity control (blanked in place, and blanked
something).
The banner pin now binds the ARGUMENT — the row is derived from `boundPort` —
and tolerates whatever else the call grows, which is the division of labour
the two tiers imply: the per-PR sibling keeps the byte-exact line and reddens
on the PR that moves it. That this is narrower rather than looser is proven in
the test on synthetic text: the matcher rejects `resolveAuthBaseUrl(port)` and
`resolveAuthBaseUrl(requestedPort, boundProtocol)`, and a standing negative
asserts neither requested-port spelling is in `serve.ts`.
⛔ No test renamed, skipped or deleted, and no assertion dropped: the describe
gains four assertions and loses none.
Claude-Session: https://claude.ai/code/session_01DvvamiacK328idtBYJBxV3
Co-authored-by: Claude <noreply@anthropic.com>
0 commit comments