Skip to content

Commit 69f42d3

Browse files
committed
fix(spec): two step-18 D3 entries stop naming sortField as a detail-entry key
The detail-entry closure's replacement listed `sortField?` among the keys to write, and the record:line_items closure sent `sortField` to the detail entry; both are false once the key is a tombstone there. Claude-Session: https://claude.ai/code/session_01T9u38rswFp5Rw8DswRUReJ Co-authored-by: Claude <noreply@anthropic.com>
1 parent 2926ee9 commit 69f42d3

3 files changed

Lines changed: 10 additions & 8 deletions

File tree

‎packages/spec/src/migrations/entries/semantic/18.ui-object-master-detail-form-details-closed.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export const entry: SemanticMigration = {
2121
+ 'grid columns), including `scale` on a column that declares no `type` and whose `name` is a '
2222
+ '`currency` field of the entry\'s `childObject`',
2323
replacement: 'each entry is `{ childObject, relationshipField?, columns?, formFields?, '
24-
+ 'inlineMode?, amountField?, sortField?, totalField?, title?, minRows?, maxRows?, addLabel? }` '
24+
+ 'inlineMode?, amountField?, totalField?, title?, minRows?, maxRows?, addLabel? }` '
2525
+ '— the keys the renderer reads — with `inlineMode` one of `grid` / `form`. Each column is the '
2626
+ 'strict, name-keyed inline grid column a relationship field\'s `inlineColumns` takes — '
2727
+ '`{ name, label?, type?, … }`, where `{ name }` alone hydrates the rest from the child '

‎packages/spec/src/migrations/entries/semantic/18.ui-record-line-items-props-closed.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,10 @@ export const entry: SemanticMigration = {
2626
+ '`{ name, label?, type?, options?, … }`. Write `name` where a column said `field` (or '
2727
+ '`fieldName`, `key`); declare `label`, `type` and `options` on the column, because this block '
2828
+ 'draws a column exactly as declared and hydrates nothing from the child object\'s field; '
29-
+ 'delete `scale` from a column declaring `type: \'currency\'`; delete `addLabel`, `sortField`, '
30-
+ '`formFields` and `inlineMode`, which belong to an `object-master-detail-form` detail entry and '
31-
+ 'are not read here, and any other key the shape does not declare.',
29+
+ 'delete `scale` from a column declaring `type: \'currency\'`; delete `addLabel`, `formFields` '
30+
+ 'and `inlineMode`, which belong to an `object-master-detail-form` detail entry and are not read '
31+
+ 'here, `sortField`, which no block takes (the detail entry derives the line-position field from '
32+
+ 'the child object), and any other key the shape does not declare.',
3233
reason: 'The block draws one inline grid of the record\'s child rows, through the same objectui '
3334
+ 'grid as the other three carriers of the inline grid column, but it had no `ComponentPropsMap` '
3435
+ 'row: it was the one entry on the string-arm registration ledger, so the component-props gate '

‎packages/spec/src/migrations/registry.ts‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19956,7 +19956,7 @@ const step18: MigrationStep = {
1995619956
+ 'grid columns), including `scale` on a column that declares no `type` and whose `name` is a '
1995719957
+ '`currency` field of the entry\'s `childObject`',
1995819958
replacement: 'each entry is `{ childObject, relationshipField?, columns?, formFields?, '
19959-
+ 'inlineMode?, amountField?, sortField?, totalField?, title?, minRows?, maxRows?, addLabel? }` '
19959+
+ 'inlineMode?, amountField?, totalField?, title?, minRows?, maxRows?, addLabel? }` '
1996019960
+ '— the keys the renderer reads — with `inlineMode` one of `grid` / `form`. Each column is the '
1996119961
+ 'strict, name-keyed inline grid column a relationship field\'s `inlineColumns` takes — '
1996219962
+ '`{ name, label?, type?, … }`, where `{ name }` alone hydrates the rest from the child '
@@ -20096,9 +20096,10 @@ const step18: MigrationStep = {
2009620096
+ '`{ name, label?, type?, options?, … }`. Write `name` where a column said `field` (or '
2009720097
+ '`fieldName`, `key`); declare `label`, `type` and `options` on the column, because this block '
2009820098
+ 'draws a column exactly as declared and hydrates nothing from the child object\'s field; '
20099-
+ 'delete `scale` from a column declaring `type: \'currency\'`; delete `addLabel`, `sortField`, '
20100-
+ '`formFields` and `inlineMode`, which belong to an `object-master-detail-form` detail entry and '
20101-
+ 'are not read here, and any other key the shape does not declare.',
20099+
+ 'delete `scale` from a column declaring `type: \'currency\'`; delete `addLabel`, `formFields` '
20100+
+ 'and `inlineMode`, which belong to an `object-master-detail-form` detail entry and are not read '
20101+
+ 'here, `sortField`, which no block takes (the detail entry derives the line-position field from '
20102+
+ 'the child object), and any other key the shape does not declare.',
2010220103
reason: 'The block draws one inline grid of the record\'s child rows, through the same objectui '
2010320104
+ 'grid as the other three carriers of the inline grid column, but it had no `ComponentPropsMap` '
2010420105
+ 'row: it was the one entry on the string-arm registration ledger, so the component-props gate '

0 commit comments

Comments
 (0)