Skip to content

Commit 77a246b

Browse files
committed
fix(lint): the chart-field-unknown explanation drops its os migrate meta sentence; the fix line carries the house form
Claude-Session: https://claude.ai/code/session_01VZqqwTj2wsihZEbfT6yyYN Co-authored-by: Claude <noreply@anthropic.com>
1 parent 2e5eb5a commit 77a246b

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

‎packages/lint/src/rule-explanations.ts‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -447,10 +447,9 @@ const CHART_FIELD_UNKNOWN_EXPLANATION: RuleExplanation = {
447447
'names an entry of the widget\'s selection is not reported, and a selection entry that does not ' +
448448
'resolve is `widget-dimension-unknown` or `widget-measure-unknown`\'s error.',
449449
'To fix it, delete the key: `chartConfig.xAxis`, `chartConfig.yAxis` and `chartConfig.series` are ' +
450-
'refused on a dataset-bound widget (ADR-0021). `os migrate meta --from 17` lists the mechanical ' +
451-
'edits for existing sources. Post-cutover data is keyed by the dataset\'s measure NAME, not the ' +
452-
'base column. Suppress with `suppressWarnings: [\'chart-field-unknown\']` if the inert key is ' +
453-
'intentional.',
450+
'refused on a dataset-bound widget (ADR-0021). Post-cutover data is keyed by the dataset\'s ' +
451+
'measure NAME, not the base column. Suppress with `suppressWarnings: [\'chart-field-unknown\']` ' +
452+
'if the inert key is intentional.',
454453
],
455454
};
456455

‎packages/lint/src/validate-widget-bindings.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1985,7 +1985,7 @@ describe('[#22161] one-line verdicts — the rule ids this file shortened', () =
19851985
[WIDGET_FILTER_FIELD_UNKNOWN]: ['`runtimeFilter`', 'widens the scope', 'nothing reports the miss', 'filter-token-unknown'],
19861986
[WIDGET_FILTER_FIELD_NOT_INCLUDED]: ['`assertDeclared`', '`runtimeFilter`', 'joins ONLY'],
19871987
[WIDGET_SORTBY_UNSELECTED]: ['`resolveOrdering`', 'DATASET_INVALID', 'query RESULT', 'DashboardWidgetOptionsSchema.sortBy'],
1988-
[CHART_FIELD_UNKNOWN]: ['`axisPresentation`', 'BY NAME', 'silent no-op', 'os migrate meta --from 17'],
1988+
[CHART_FIELD_UNKNOWN]: ['`axisPresentation`', 'BY NAME', 'silent no-op', 'refused on a dataset-bound widget'],
19891989
[CHART_MEASURES_MISSING]: ['DatasetWidget.tsx', 'widget-measures-missing', 'chart-dimensions-missing'],
19901990
[WIDGET_MEASURES_MISSING]: ['`solid-gauge`', '`pivot`', 'one KPI number the tile exists to show'],
19911991
[CHART_DIMENSIONS_MISSING]: ['METRIC_TYPES.has(widgetType) || dimensions.length === 0', 'declared chart family is simply gone', '`metric` or `kpi`'],

0 commit comments

Comments
 (0)