Skip to content

Commit a2d5d53

Browse files
committed
docs(spec): restamp the turso ?authToken= reading on the @libsql/core 0.18.0 this tree now pins
The TSDoc of CREDENTIAL_URL_QUERY_PARAMS says each entry is measured "in the versions pinned by this tree" and named @libsql/core 0.17.4; with the client lifted to ^0.18.0 the tree pins only core 0.18.0, so the label would have been false in the release that ships it. Its echo in driver-credential-refusal.test.ts moves with it. Re-measured on the installed @libsql/core 0.18.0 (expandConfig, with a config-level authToken 'BINDER'): - url ?authToken=URLTOK -> authToken URLTOK (the URL overrides) - url ?auth%54oken=URLTOK -> authToken URLTOK (key percent-decoded) - url ?AuthToken= / ?token= -> URL_PARAM_NOT_SUPPORTED - control, no query string -> authToken BINDER Identical to the 0.17.4 reading; core 0.17.4 and 0.18.0 differ only in their package.json version. Claude-Session: https://claude.ai/code/session_018gA1pE6eJtwHhqx72G8U9X Co-authored-by: Claude <noreply@anthropic.com>
1 parent 56e4219 commit a2d5d53

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎packages/spec/src/data/driver/common.zod.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ export function urlUserinfoUsername(value: string): string | undefined {
266266
* Every entry is MEASURED against the client the driver actually hands the URL
267267
* to, in the versions pinned by this tree — never inferred from documentation:
268268
*
269-
* - `turso: ['authToken']` — `@libsql/core@0.17.4` `expandConfig` reads
269+
* - `turso: ['authToken']` — `@libsql/core@0.18.0` `expandConfig` reads
270270
* `?authToken=` from the parsed URL and assigns it OVER the config-level
271271
* `authToken`, so a query-embedded token does not merely authenticate: it
272272
* silently overrides the secret the datasource binder injects at connect.

‎packages/spec/src/data/driver/driver-credential-refusal.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ describe.each(URL_FAMILY)('$name — URL-embedded credential refusal (#8082)', (
322322
/**
323323
* The query-parameter spelling of the same secret (#8337) — refused only where
324324
* a MEASURED client reads it: turso `url`/`syncUrl` `?authToken=`
325-
* (`@libsql/core@0.17.4` assigns it OVER the binder-injected token) and
325+
* (`@libsql/core@0.18.0` assigns it OVER the binder-injected token) and
326326
* postgres `url` `?password=` (`pg-connection-string@2.14.0` copies every
327327
* query parameter into the client config, winning over userinfo).
328328
*/

0 commit comments

Comments
 (0)