Repository navigation
Commit bada58f
committed
test(spec): the transactions tombstone pin discriminates its own subject
`packages/spec/src/data/driver.test.ts` pinned the `transactions` retired-key
prescription with a regex requiring only that `METHOD PRESENCE` and
`beginTransaction` appear somewhere in the thrown message. #18890 rewrote that
prescription's opening from "gated on METHOD PRESENCE" to "gated on the
DRIVER'S DECLARATION, no longer on METHOD PRESENCE alone" — and the old regex
matches BOTH. Reverting the prescription to the now-false sentence kept the
test green, so the pin could not fail on the one shape it exists to catch. The
title said "points at method presence", which is the old world too.
Anchor on the two things #18890 made load-bearing instead: the negation
(`no longer on METHOD PRESENCE`) and the predicate that replaced presence
(`driverSupportsTransactions`). `beginTransaction` and `Delete the key` stay,
so nothing the old pin covered is dropped.
Deliberately NOT a ban on the phrase `METHOD PRESENCE`: `schemaSync`'s own
"Schema sync is gated on METHOD PRESENCE" sentence in driver.zod.ts is true of
the runtime today and is untouched.
Test-only. No runtime file, no published surface.
Claude-Session: https://claude.ai/code/session_01JbZnqu8bt6YqfJsr9vaFb3
Co-authored-by: Claude <noreply@anthropic.com>1 parent 0ec8185 commit bada58f
1 file changed
Lines changed: 9 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | | - | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
125 | 132 | | |
126 | | - | |
| 133 | + | |
127 | 134 | | |
128 | 135 | | |
129 | 136 | | |
| |||
0 commit comments