Repository navigation
Commit bfa23a8
Part of #19900
Clause-②: no
## The pending release note this corrects
This PR edits one sentence of
`.changeset/19846-automation-caller-param-keys.md`, the pending note for
`AutomationContext.callerParamKeys` (PR #19899). The note's frontmatter
covers `@objectstack/spec`, `@objectstack/runtime` and
`@objectstack/service-automation`. Nothing else in the note changes,
frontmatter included (1 line changed: +1 / −1).
**Before:**
> Record-change, schedule, time-relative and webhook triggers, and code
calling `execute` directly, leave it absent.
**After:**
> Record-change, time-relative and webhook triggers, and code calling
`execute` directly, leave it absent; the schedule trigger, whose run has
no caller, states an empty list (#19900).
**What made it false:** PR #19982, landed as `ae7a35a63b`. Since that
commit, `ScheduleTrigger` sets `callerParamKeys: []` on every run
context it builds, so the schedule trigger no longer leaves the key
absent. PR #19982's own changeset
(`.changeset/19900-schedule-caller-param-keys.md`) reaches only the
`@objectstack/trigger-schedule` and `@objectstack/spec` CHANGELOGs. The
`@objectstack/runtime` and `@objectstack/service-automation` CHANGELOGs
would publish this sentence unchanged.
## The gate is expected to stay red
`node scripts/check-empty-changeset.mjs --base origin/main` exits 1 on
this head. This is a DELIBERATE CORRECTION of a foreign pending note,
and the gate stays red on it by design until a person confirms the
rewritten sentence (the seat's ruled path: ruling D on #17712, and the
landing rule added in #19970). Its output begins:
```text
Diffing HEAD from ae7a35a (merge base with origin/main).
✓ No empty-frontmatter changeset introduced by this diff (1 declaring changeset(s) added).
This PR changes a changeset it did not add:
.changeset/19846-automation-caller-param-keys.md
present on the merge base and CHANGED by this PR -- this is somebody else's release note
```
The DELIBERATE CORRECTION remedy it prints is: "do NOT restore it -- say
so on the PR and get it confirmed". This section is that statement.
## `skip-changeset`: not applied
Two readings, and they agree. (1) This diff changes release-note text
that `changeset version` will compile into three published CHANGELOGs,
so it is not a diff that publishes nothing. (2) The standing rule for a
PR that edits an existing `.changeset/*.md` is never to apply
`skip-changeset`: the red gate is correct, and the confirmation goes
through the PR text.
## Gates (head `465a0f9342`)
`node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack
--commands` derived 19 commands from the change set (merge base
`ae7a35a63`). All 19 ran with their exit codes recorded. 18 exited 0,
and `check-empty-changeset.mjs --base origin/main` exited 1, as expected
above. `pnpm check:changeset-gate-self-tests` exited 0. The `--ran`
reconciliation reads: 19 derived, 19 run, 0 NOT-MEASURED.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01Evb5jFDZGKQE9KG4jbMfMF)_
Co-authored-by: Claude <noreply@anthropic.com>
1 parent a666e94 commit bfa23a8
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
0 commit comments