Repository navigation
Commit c183a12
* feat(spec)!: promote `userFilters.allowAddTab`, then close UserFiltersSchema (#5073)
`UserFiltersSchema` was the last shape #4001 批 18 left open in `ui/view.zod.ts`
whose blocker was a capability question rather than a strictness one.
objectui's renderer reads `config.allowAddTab` and renders an add-tab affordance
from it (`plugin-list/src/UserFilters.tsx:182`/`:742`), and its own schema
declared the key — the difference between the two shapes was exactly that one
key. Because `saveMetaItem` validates with `safeParse` but persists the ORIGINAL
body, the stripped key still reached the renderer, so the capability worked.
Closing without declaring it would have 422'd a shipped config with a message
naming a key the author was right to write (finding 7), not converted a silent
failure into a loud one.
Maintainer adjudication (2026-08-04) chose promote-then-close in one PR:
- `allowAddTab` is DECLARED, so the capability is discoverable from the contract
(JSON Schema / Studio SchemaForm / AI authors) instead of one React file. The
`.describe()` is scoped to what the renderer really does — it renders the
affordance; the button carries no click handler today, filed separately, and
promising more would be PD#10.
- `UserFiltersSchema` closes behind it, in the same change, so there is no state
where the key is declared but its neighbours still vanish silently.
Closing flips `ObjectUserFiltersSchema` (`.omit()`ed off the base, and `.omit()`
inherits posture) from dropping the page-only keys to rejecting them — 批 6e's
question, and the wanted answer: the CLI lint already reported them, so the two
doors now agree. But `.omit()` also inherits the base's error map, whose
`knownKeys` still listed the omitted keys: measured on the flip, `tab` was
answered "Did you mean `tab` -> `tabs`?", steering the author at the one key
that surface refuses. The object variant now builds its map over the OMITTED
shape (shape still derived by `.omit()`, so #2231 holds) with `guidance`
pointing all three page-only keys at `listViews`.
Ledger: view.zod.ts Class 6 -> 5 authorable; counts regenerated via
`gen:strictness-ledger` (ui/ strict 117 -> 119, strip 76 -> 75, sites 50 -> 51).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ehu85kbvMcrNTUJjwxvLJ9
* build(spec): regenerate strictness counts from the merged tree (#5073 + #5221)
The merge with origin/main brought in #5221 (`chart.zod.ts` gains
`ChartDrillDownSchema`). Git text-merged the GENERATED counts file cleanly and
WRONGLY — the ledger's own documented failure mode: each side's row deltas do
not overlap, so the subtotals merge clean while naming a tree neither branch
ever had (483/199, missing #5221's site).
Regenerated via `gen:strictness-ledger` from the merged tree, which is the only
state in which the numbers are right: 484 sites / ui 200, strict 244 / ui 120.
Both hand-written prose rows survive untouched — `view.zod.ts` (this PR) and
`chart.zod.ts` (#5221) are different rows.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ehu85kbvMcrNTUJjwxvLJ9
* docs(spec): name the renderer-gap issue (#5236) in the JSDoc and ledger row
Both spots described the add-tab button's missing click handler as "filed
separately" without the number, which is the shape AGENTS.md #13 warns about —
a decision nobody can find. Now the reader of either surface can reach the
evidence.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ehu85kbvMcrNTUJjwxvLJ9
---------
Co-authored-by: Claude <noreply@anthropic.com>
1 parent c142ced commit c183a12
11 files changed
Lines changed: 284 additions & 100 deletions
File tree
- .changeset
- content/docs/references/ui
- docs/audits
- packages/spec
- scripts
- src/ui
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
375 | 375 | | |
376 | 376 | | |
377 | 377 | | |
378 | | - | |
| 378 | + | |
379 | 379 | | |
380 | 380 | | |
381 | 381 | | |
| |||
653 | 653 | | |
654 | 654 | | |
655 | 655 | | |
| 656 | + | |
656 | 657 | | |
657 | 658 | | |
658 | 659 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
| 24 | + | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| |||
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | | - | |
| 164 | + | |
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
| |||
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
179 | | - | |
| 179 | + | |
180 | 180 | | |
181 | | - | |
| 181 | + | |
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | | - | |
| 185 | + | |
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
| |||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7964 | 7964 | | |
7965 | 7965 | | |
7966 | 7966 | | |
| 7967 | + | |
7967 | 7968 | | |
7968 | 7969 | | |
7969 | 7970 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
233 | | - | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
234 | 239 | | |
235 | 240 | | |
236 | 241 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
28 | 32 | | |
29 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
30 | 39 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
35 | 56 | | |
36 | 57 | | |
37 | 58 | | |
| |||
0 commit comments