Skip to content

Commit cc83d5c

Browse files
committed
fix(objectql): keep the tracker id out of the door's refusal message
`pnpm check:doc-authoring` exited 1 on 438d918. The gate's own site list, verbatim: ✗ NEW internal issue-id reference(s) in sibling-package string prose: packages/objectql/src/text-operator-declared-type-door.ts #14079 (0 pinned, 1 measured) :265 'this door the predicate is answered by the declared no-match rule (#14079) — a positive ' One site, one id, in the refusal message this door hands the caller. The message reaches authors, operators and generated surfaces, none of whom can resolve a tracker id; the rule's own words are 「处理 issue 时犯的错应 该总结成经验,保留 issue id 没有意义」. The sentence already carries the lesson — a positive text operator matches no row and $notContains matches every row — so the id is dropped from the string and moved to an adjacent `//` comment for the source reader who CAN resolve it. The module docblock keeps its references, which the gate does not read as runtime prose. The baseline file is untouched: an entry there is maintainer-only and would have weakened a ratchet to buy green. Measured, redirect-then-$?: exit 1 before, exit 0 after. The door suite still passes 22/22 — no pin asserted that id (`mustMention` carries the key, the declared type and the operator, none of which moved). Claude-Session: https://claude.ai/code/session_01XTBcV7zZHmokdyQgXjbyEU Co-authored-by: Claude <noreply@anthropic.com>
1 parent 438d918 commit cc83d5c

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎packages/objectql/src/text-operator-declared-type-door.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,9 @@ export function assertTextOperatorTargetsAreStringCapable(
262262
+ `${hit.operator} at a declared ${declared} at ${hit.path}. A ${hit.declaredType} value is `
263263
+ 'never a string on any backend, so no record can be matched by reading one as text — the '
264264
+ 'operator can only be aimed at this field by mistake. The filter was NOT applied: beneath '
265-
+ 'this door the predicate is answered by the declared no-match rule (#14079) — a positive '
265+
// The stored-value row is #14079's; the id stays in this comment rather than in
266+
// the message, which reaches authors and operators who cannot resolve a tracker id.
267+
+ 'this door the predicate is answered by the declared no-match rule — a positive '
266268
+ 'text operator matches NO row and $notContains matches EVERY row — an answer no caller can '
267269
+ `tell apart from a real result set. Compare '${hit.field}' with an operator its declared `
268270
+ 'type can answer ($eq / $ne / $in / $gt / $gte / $lt / $lte, a range for a temporal or '

0 commit comments

Comments
 (0)