Repository navigation
Commit f5622a7
committed
fix(spec): also correct the D3-per-family house rule in migrations/registry.ts:9 (#17152)
Round 2: the hand-written module docblock of packages/spec/src/migrations/registry.ts
(lines 1-14) is outside every <os-generated ...> region -- scripts/build-migration-registry.ts
splices only the marked regions, and the file's own :46 comment says so ("hand-written,
outside the generated regions"). This is the exact sentence the card quotes and the ruling
targets ("its `semantic` list is the non-lossless residue D2 could not express", present since
the original ADR-0087 commit 16b4bf6), so leaving it unrewritten would let a merge close
#17152 while the targeted sentence still stood.
Rewrites it to the same meaning as the types.ts fix already on this branch: one D3 entry per
retirement family, even when a lossless D2 conversion also exists for it; D2 carries the
mechanical data repair only.
Verified the generator preserves it: `check:migration-registry` is green, and running
`gen:migration-registry` directly reproduces byte-identical output (sha256 unchanged) with the
new sentence present and the old one gone -- confirming the marked-region splice never touches
this header.
Adds a `patch` changeset. Re-measured (build + grep with a positive control) rather than
assumed: the types.ts sentence ships verbatim into the published dist/index.d.ts and
dist/index.d.mts (TypeScript preserves the JSDoc attached to the exported SemanticMigration
type), so this docblock text is part of the published surface and the earlier skip-changeset
label no longer holds. The registry.ts sentence does not ship to dist (same positive control,
zero hits either wording) but travels in the same changeset since it is one fix.1 parent 859b5c8 commit f5622a7
2 files changed
Lines changed: 11 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
0 commit comments