Skip to content

Commit fd8fd92

Browse files
committed
test(spec): shared test titles state each cited decision in words instead of a tracker number (stage 12)
Class (e), the third area: the 85 string literals under packages/spec/src/shared/ that carried a tracker id (95 ids) now carry none. Where the number stood in for a decision, the literal states it (for example "the two maps the first fold MISSED", "the fix-first order survives the new set", "the prescription must not point at the retired ETL layer"); where the title already says the decision, the number is dropped. Three placeholder ids (#0000) in synthetic fixtures cite no record and are dropped. Text only: 73 test titles and 12 declared non-title strings, one line per literal. No comment, assertion, identifier or non-test file moves. Claude-Session: https://claude.ai/code/session_01T9u38rswFp5Rw8DswRUReJ Co-authored-by: Claude <noreply@anthropic.com>
1 parent 72b6333 commit fd8fd92

21 files changed

Lines changed: 85 additions & 85 deletions

‎packages/spec/src/shared/alias-integrity.test.ts‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ describe('alias integrity — coverage', () => {
513513
expect(unreached, 'these alias tables are not reachable from any module export, so nothing judges them').toEqual([]);
514514
});
515515

516-
it('NOTHING in packages/spec calls `strictUnknownKeyError` directly any more (#5593)', () => {
516+
it('NOTHING in packages/spec calls `strictUnknownKeyError` directly any more', () => {
517517
// This was a shrink-only ratchet at 44 — the pre-helper wiring, which hands
518518
// the factory a hand-transcribed `knownKeys` array instead of a shape.
519519
// #5593 migrated the last of them, so it is a hard ZERO and the assertion
@@ -767,7 +767,7 @@ describe('alias integrity — every table is a true claim about its schema', ()
767767
expect(broken.sort()).toEqual([]);
768768
});
769769

770-
it('no two alias keys in one table collapse onto the same probe (#5481)', () => {
770+
it('no two alias keys in one table collapse onto the same probe', () => {
771771
// The table is indexed by `aliasProbe(key)`, so a colliding pair does not
772772
// produce two entries — it produces one, decided by source order, with the
773773
// earlier key gone before any author can reach it. Judged with the REAL
@@ -809,7 +809,7 @@ describe('alias integrity — every table is a true claim about its schema', ()
809809
expect([...PROSE_ALIAS_TARGETS].filter((x) => !used.has(x)).sort()).toEqual([]);
810810
});
811811

812-
it('no guidance SET member is itself a declared key, and no two entries claim one key (#6619)', () => {
812+
it('no guidance SET member is itself a declared key, and no two entries claim one key', () => {
813813
// The set-keyed guidance form arrived with #6619's fold of the three
814814
// hand-written `$ZodErrorMap`s — maps that, being hand-rolled, no registry
815815
// saw and nothing judged (#6416's blind spot). Folding them in is only
@@ -849,7 +849,7 @@ describe('alias integrity — every table is a true claim about its schema', ()
849849
expect(broken.sort()).toEqual([]);
850850
});
851851

852-
it('every pattern-keyed set carries examples that really match it and are really rejected (#6619)', () => {
852+
it('every pattern-keyed set carries examples that really match it and are really rejected', () => {
853853
// A pattern is an OPEN family, so the dead-entry question cannot be asked
854854
// of its membership the way it is of a list — the visibility pattern
855855
// deliberately also matches the canonical `visibleWhen`, which the shape
@@ -880,7 +880,7 @@ describe('alias integrity — every table is a true claim about its schema', ()
880880
expect(broken.sort()).toEqual([]);
881881
});
882882

883-
it('no alias row is dead on arrival because a guidanceSet in the same table already consumes it (#7889)', () => {
883+
it('no alias row is dead on arrival because a guidanceSet in the same table already consumes it', () => {
884884
// The live-table verdict. If this ever turns red on a real schema, the fix
885885
// is at the authoring site (drop the row, or fold the key into the set's
886886
// prescription) — never here, and never a change to the predicate that
@@ -904,7 +904,7 @@ describe('alias integrity — every table is a true claim about its schema', ()
904904
).toBeGreaterThan(0);
905905
});
906906

907-
it('the guidanceSet-reachability check can actually go red — a planted dead row, no live schema touched (#7889)', () => {
907+
it('the guidanceSet-reachability check can actually go red — a planted dead row, no live schema touched', () => {
908908
// Self-test, per the triage ruling: prove the gate can fail before trusting
909909
// that it passing on the live table means anything. Entirely synthetic —
910910
// `unreachableAliasRows` only reads `options.aliases` / `options.guidanceSets`,
@@ -914,7 +914,7 @@ describe('alias integrity — every table is a true claim about its schema', ()
914914
const planted: StrictObjectDeclaration[] = [{
915915
options: {
916916
surface: 'synthetic reachability probe',
917-
history: 'n/a — planted for #7889 self-test',
917+
history: 'n/a — planted for the reachability self-test',
918918
aliases: { visibleIf: 'visibleWhen' },
919919
guidanceSets: [{
920920
name: 'SYNTHETIC_VIS_PATTERN',
@@ -936,7 +936,7 @@ describe('alias integrity — every table is a true claim about its schema', ()
936936
const reachable: StrictObjectDeclaration[] = [{
937937
options: {
938938
surface: 'synthetic reachability probe (no set)',
939-
history: 'n/a — planted for #7889 self-test',
939+
history: 'n/a — planted for the reachability self-test',
940940
aliases: { visibleIf: 'visibleWhen' },
941941
},
942942
shape: emptyShape,
@@ -949,7 +949,7 @@ describe('alias integrity — every table is a true claim about its schema', ()
949949
const nonMatching: StrictObjectDeclaration[] = [{
950950
options: {
951951
surface: 'synthetic reachability probe (non-matching set)',
952-
history: 'n/a — planted for #7889 self-test',
952+
history: 'n/a — planted for the reachability self-test',
953953
aliases: { disabled: 'readonly' },
954954
guidanceSets: [{
955955
name: 'SYNTHETIC_VIS_PATTERN',
@@ -963,7 +963,7 @@ describe('alias integrity — every table is a true claim about its schema', ()
963963
expect(unreachableAliasRows(nonMatching)).toEqual([]);
964964
});
965965

966-
it('the three #6416 hand-written maps are FOLDED and judged here — the blind spot stays closed (#6619)', () => {
966+
it('the three hand-written error maps are FOLDED and judged here — the blind spot stays closed', () => {
967967
// The reason #6619 existed: `strictVisibilityError`,
968968
// `strictWidgetAnalyticsError` and `strictTenancyError` were hand-rolled
969969
// `$ZodErrorMap`s, so their alias pointers and prescriptions registered in
@@ -1008,7 +1008,7 @@ describe('alias integrity — every table is a true claim about its schema', ()
10081008
.toEqual(['crossTenantAccess', 'organizationField', 'strategy']);
10091009
});
10101010

1011-
it('no live surface still reports the shared view/page FAMILY name (#8202)', () => {
1011+
it('no live surface still reports the shared view/page FAMILY name', () => {
10121012
// `VISIBILITY_STRICT_OPTIONS.surface` is the family's name, and every
10131013
// consumer overrides it with its own shape's (`'this form field'` /
10141014
// `'this form section'` / `'this page component'`) — because since #7887
@@ -1028,7 +1028,7 @@ describe('alias integrity — every table is a true claim about its schema', ()
10281028
).toEqual([]);
10291029
});
10301030

1031-
it('the two maps #6619 MISSED are folded and judged here too (#6805)', () => {
1031+
it('the two maps the first fold MISSED are folded and judged here too', () => {
10321032
// #6619's inventory was two short, and both survivors were the same shape
10331033
// as the three above — `unrecognized_keys` prescription tables attached to
10341034
// a `.strict()` object through `{ error: … }`, seen by no registry. The
@@ -1055,7 +1055,7 @@ describe('alias integrity — every table is a true claim about its schema', ()
10551055
expect(Object.keys(capabilities!.options.guidance ?? {}).sort()).toEqual(['mru', 'trash']);
10561056
});
10571057

1058-
it('NO module outside the shared helpers writes its own `unrecognized_keys` map (#6805)', () => {
1058+
it('NO module outside the shared helpers writes its own `unrecognized_keys` map', () => {
10591059
// The class, not the instances. Both closure pins above name surfaces, so
10601060
// each only holds the line it was written for — #6416 named three, and the
10611061
// inventory that produced the number was two short. A pin over the SHAPE
@@ -1097,11 +1097,11 @@ describe('alias integrity — every table is a true claim about its schema', ()
10971097
offenders.sort(),
10981098
'build the shape with `strictObject(options, shape)` and put the prescriptions in '
10991099
+ '`guidance` / `guidanceSets` — a hand-rolled map registers in no registry, so its '
1100-
+ 'aliases and prescriptions are unmeasured rather than clean (#6416/#6619/#6805)',
1100+
+ 'aliases and prescriptions are unmeasured rather than clean',
11011101
).toEqual([]);
11021102
});
11031103

1104-
it('…and that scan is alive: the pre-fold shape is found, prose and the two out-of-class maps are not (#6805)', () => {
1104+
it('…and that scan is alive: the pre-fold shape is found, prose and the two out-of-class maps are not', () => {
11051105
// Anti-vacuity for the verdict above, which asserts that a search came back
11061106
// EMPTY — the shape that passes just as well when the instrument is dead.
11071107
// Four controls, each closing a different way it could be.

‎packages/spec/src/shared/duration.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export type IsoDurationSeconds = Assert<
4242
Eq<z.input<typeof DurationSeconds>, z.infer<typeof DurationSeconds>>
4343
>;
4444

45-
describe('the closed duration vocabulary — exactly two units (#18122)', () => {
45+
describe('the closed duration vocabulary — exactly two units', () => {
4646
it('declares milliseconds and seconds, and no speculative third unit', async () => {
4747
// ⛔ `DurationMinutes` / `DurationHours` / `DurationDays` are added when a
4848
// real row needs one, in the PR that converts it — the unit set is derived

‎packages/spec/src/shared/editability-boundary.test.ts‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ const EDITABILITY_KEYS = ['disabled', 'disabledWhen', 'readonly', 'readOnly', 'r
9999
// ===========================================================================
100100
// 1. The guidance reaches an author — on the real parse error
101101
// ===========================================================================
102-
describe('#7887 — the boundary prescription an author actually sees', () => {
102+
describe('editability lives on fields — the boundary prescription an author actually sees', () => {
103103
it.each(VISIBILITY_ONLY)('%s answers `disabled` with the boundary, not a bare refusal', (_n, schema, base) => {
104104
const m = unknownKeyMessage(schema, { ...base, disabled: true });
105105
expect(m).toContain('Editability is a FIELD-level concern');
@@ -128,7 +128,7 @@ describe('#7887 — the boundary prescription an author actually sees', () => {
128128
for (const key of ['disabled', 'readonly', 'editable']) expect(m).toContain(`\`${key}\``);
129129
});
130130

131-
it.each(VISIBILITY_ONLY)('%s still puts the history sentence last (the #5955 order survives the new set)', (_n, schema, base) => {
131+
it.each(VISIBILITY_ONLY)('%s still puts the history sentence last (the fix-first order survives the new set)', (_n, schema, base) => {
132132
const m = unknownKeyMessage(schema, { ...base, disabled: true });
133133
const history = 'Before ADR-0089 D3a these were dropped silently';
134134
expect(m.indexOf('Editability is a FIELD-level concern')).toBeLessThan(m.indexOf(history));
@@ -138,7 +138,7 @@ describe('#7887 — the boundary prescription an author actually sees', () => {
138138
// ===========================================================================
139139
// 2. It names `readonlyWhen` — and must never name `disabledWhen`
140140
// ===========================================================================
141-
describe('#7887 — the prescription points at a key that exists', () => {
141+
describe('the prescription points at a key that exists', () => {
142142
it.each(VISIBILITY_ONLY)('%s names the field-level `readonly` / `readonlyWhen` pair', (_n, schema, base) => {
143143
const m = unknownKeyMessage(schema, { ...base, disabled: true });
144144
expect(m).toContain('`readonly: true`');
@@ -168,7 +168,7 @@ describe('#7887 — the prescription points at a key that exists', () => {
168168
// ===========================================================================
169169
// 3. The field surface is UNCHANGED — the shared-table trap
170170
// ===========================================================================
171-
describe('#7887 — `FormFieldSchema` sees exactly what it saw before', () => {
171+
describe('`FormFieldSchema` sees exactly what it saw before', () => {
172172
it('`disabled` on a form field still renames onto `readonly`, with no boundary text', () => {
173173
const m = unknownKeyMessage(FormFieldSchema, { ...FORM_FIELD, disabled: true });
174174
expect(m).toContain('Did you mean `disabled` → `readonly`?');
@@ -217,7 +217,7 @@ describe('#7887 — `FormFieldSchema` sees exactly what it saw before', () => {
217217
// ===========================================================================
218218
// 4. Acceptance is byte-identical — a guidance string is not a key
219219
// ===========================================================================
220-
describe('#7887 — no acceptance change', () => {
220+
describe('no acceptance change', () => {
221221
it.each(VISIBILITY_ONLY)('%s still REJECTS every editability spelling', (_n, schema, base) => {
222222
for (const key of EDITABILITY_KEYS) {
223223
expect(
@@ -277,7 +277,7 @@ describe('#7887 — no acceptance change', () => {
277277
// ===========================================================================
278278
// 5. #8202 — every shape names ITSELF, so the two answers cannot be swapped
279279
// ===========================================================================
280-
describe('#8202 — the rejection says WHICH shape refused the key', () => {
280+
describe('the rejection says WHICH shape refused the key', () => {
281281
/** Each shape, a probe body, and the name its rejection must give itself. */
282282
const NAMED: ReadonlyArray<[string, { safeParse: (v: unknown) => { success: boolean; error?: unknown } }, object, string]> = [
283283
['FormFieldSchema', FormFieldSchema, FORM_FIELD, 'this form field'],
@@ -341,7 +341,7 @@ describe('#8202 — the rejection says WHICH shape refused the key', () => {
341341
// ===========================================================================
342342
// 6. #8201 — `SelectOptionSchema` inherits the ruling, with its OWN answer
343343
// ===========================================================================
344-
describe('#8201 — an option is offered or withheld, never shown-but-unselectable', () => {
344+
describe('an option is offered or withheld, never shown-but-unselectable', () => {
345345
const OPTION_TEXT = 'Editability is not a per-OPTION concern';
346346

347347
it('`disabled` on an option reaches the boundary, rendered as the template bullet', () => {

‎packages/spec/src/shared/error-map.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ describe('formatZodError', () => {
187187
// mistake = the same key reported N times, which is why `view.zod.ts`'s
188188
// `submitBehavior` reached for `discriminatedUnion` in the first place. Both
189189
// directions are pinned below.
190-
describe('[#4971] formatZodError expands invalid_union branches', () => {
190+
describe('formatZodError expands invalid_union branches', () => {
191191
// The campaign's shape: a string form OR a closed object form.
192192
//
193193
// [#19581] The closed arm is a REAL PRODUCT DOOR — `NormalizedFilterSchema`,
@@ -402,7 +402,7 @@ describe('safeParsePretty', () => {
402402
// `z.record` key schema there is `z.string()` or an enum — #5389's dormancy
403403
// table), which is why these fixtures are local schemas: the defect is in the
404404
// CONSUMER, and the consumer is reachable from any caller's schema.
405-
describe('[#5389] formatZodError descends invalid_key / invalid_element', () => {
405+
describe('formatZodError descends invalid_key / invalid_element', () => {
406406
const SnakeKey = z
407407
.string()
408408
.regex(/^[a-z][a-z0-9_]*$/, "Invalid identifier. Must be lowercase snake_case (e.g. 'first_name').");

‎packages/spec/src/shared/evaluated-expression.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ function issuesOf(value: unknown) {
3636
return result.success ? [] : result.error.issues.map((i) => ({ code: i.code, path: i.path.map(String).join('.'), message: i.message }));
3737
}
3838

39-
describe('EvaluatedExpressionSchema — an evaluated slot requires a non-blank `source` (#15430)', () => {
39+
describe('EvaluatedExpressionSchema — an evaluated slot requires a non-blank `source`', () => {
4040
it('REFUSES an `ast`-only envelope: one issue, at `source`, the published sentence', () => {
4141
expect(issuesOf(AST_ONLY)).toEqual([
4242
{ code: 'invalid_type', path: 'source', message: EVALUATED_EXPRESSION_SOURCE_REQUIRED },

‎packages/spec/src/shared/evaluated-slot-population.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ function persistenceSchemaCodeLines(): string[] {
107107
return hits;
108108
}
109109

110-
describe('#15811 population — no declaring position still mounts the persistence schema', () => {
110+
describe('evaluated-slot population — no declaring position still mounts the persistence schema', () => {
111111
const hits = persistenceSchemaCodeLines();
112112

113113
it('LIT CONTROL — the scan does find the name where it legitimately lives', () => {
@@ -242,7 +242,7 @@ const POSITIONS: ReadonlyArray<readonly [string, () => z.ZodType]> = [
242242
['system/settings-manifest.zod.ts:SettingsManifestSchema.visible', () => slot(SettingsManifestSchema, 'visible')],
243243
];
244244

245-
describe('#15811 — every evaluated slot refuses the two shapes no engine can run', () => {
245+
describe('every evaluated slot refuses the two shapes no engine can run', () => {
246246
it('reaches exactly the 34 declaring positions the census enumerated', () => {
247247
// A position that stops being reachable must red here rather than fall out
248248
// of the table: that silent drop is the #17630 failure in another costume.

‎packages/spec/src/shared/expression-dialect-docs.pin.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ function dialectRowsInDocTable(): string[] {
6464
return names;
6565
}
6666

67-
describe('[#6085] expression.zod.ts dialect table === ExpressionDialect', () => {
67+
describe('expression.zod.ts dialect table === ExpressionDialect', () => {
6868
const rows = dialectRowsInDocTable();
6969

7070
it('finds the table at all (anti-vacuity)', () => {
@@ -79,7 +79,7 @@ describe('[#6085] expression.zod.ts dialect table === ExpressionDialect', () =>
7979
expect([...rows].sort()).toEqual([...ExpressionDialect.options].sort());
8080
});
8181

82-
it('never re-advertises `js`, retired at #3278', () => {
82+
it('never re-advertises `js`, retired in favour of ScriptBody', () => {
8383
// The specific regression this pin was written for. `js` is not an
8484
// expression dialect at all — procedural JavaScript is the L2 authoring
8585
// surface (`ScriptBody { language: 'js' }`), so a row here would send an

‎packages/spec/src/shared/external-errors.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ describe('External error codes (ADR-0015)', () => {
2929
// REACHABLE by a client.
3030
// ---------------------------------------------------------------------------
3131

32-
describe('[#7739] EXTERNAL_ERROR_HTTP_STATUS', () => {
32+
describe('EXTERNAL_ERROR_HTTP_STATUS — each external error carries an HTTP status', () => {
3333
it('covers every code in the family — no gate can leak as a bare 500', () => {
3434
// The `satisfies Record<ExternalErrorCode, number>` makes a missing entry a
3535
// compile error; this is the runtime twin, so a code added to the map but
@@ -112,7 +112,7 @@ describe('renderDiffMessage', () => {
112112
* schema fact) and renders like every other kind: the raw kind name plus the
113113
* carried error text, so an unknown-to-a-consumer entry is still loud.
114114
*/
115-
it('renders the `unreachable` kind with the carried error text (#11166)', () => {
115+
it('renders the `unreachable` kind with the carried error text', () => {
116116
const diffs: SchemaDiffEntry[] = [
117117
{
118118
kind: 'unreachable',

‎packages/spec/src/shared/lazy-schema.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ describe('lazySchema × z.toJSONSchema identity', () => {
127127
* real instance, so before the facade aliased it every lazy reference lost its
128128
* `description` while `OS_EAGER_SCHEMAS=1` (no Proxy at all) kept it.
129129
*/
130-
describe('lazySchema × z.toJSONSchema metadata (#19101)', () => {
130+
describe('lazySchema × z.toJSONSchema — a lazy reference keeps its metadata', () => {
131131
it('a lazy reference converts exactly like the eager instance — nested and as the root', () => {
132132
const factory = () => z.record(z.string(), z.unknown()).describe('lazy-described record');
133133
const lazy = lazySchema(factory);
@@ -168,7 +168,7 @@ describe('lazySchema × z.toJSONSchema metadata (#19101)', () => {
168168
* components gain 2 descriptions, the
169169
* `os generate` IDE schema 445; description is the only key that moved.
170170
*/
171-
describe('lazy == eager on the real contract (#19101)', () => {
171+
describe('lazy == eager on the real contract', () => {
172172
const PKG_ROOT = fileURLToPath(new URL('../..', import.meta.url));
173173
const CONTRACT = new URL('../api/contract.zod.ts', import.meta.url).href;
174174
const METADATA_TYPES = new URL('../kernel/metadata-type-schemas.ts', import.meta.url).href;

‎packages/spec/src/shared/mapping.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ describe('FieldMappingSchema', () => {
7272
// so without the tombstone an authored `transform` is either accepted or
7373
// silently stripped — never named).
7474

75-
describe('[#5552] FieldMapping.transform is retired, and says so', () => {
75+
describe('FieldMapping.transform is retired, and says so', () => {
7676
const RETIRED = {
7777
source: 'order_value',
7878
target: 'order_total',

0 commit comments

Comments
 (0)