Skip to content

Commit fda0702

Browse files
committed
docs(cli): re-anchor the dead tracker citations in packages/cli's files outside src to the commits that decided them
Stage 14 of the domain:cli lane's dead-citation sweep: comment prose in packages/cli's test/**, vitest.config.ts and tsconfig.test.json. Every comment site that cited a tracker number answering 404 now cites, in ruling C+D's form C, the commit in this repository's history that decided what the line describes. 154 sites on 149 lines in 56 files, 51 numbers, 50 distinct commits; one companion line moves a stale present tense into the past (generate-skill.e2e.test.ts:35). Five sites have no deciding commit and are left as they were (#10149, #11048, #14874 x3). Comments only: 150 lines out, 150 in, every file keeps its line count. Claude-Session: https://claude.ai/code/session_01VvcEokUG1tvVxkceYfR5XB Co-authored-by: Claude <noreply@anthropic.com>
1 parent 660a9b2 commit fda0702

56 files changed

Lines changed: 150 additions & 150 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎packages/cli/test/artifact-pinned-boot.e2e.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ function runServe(env: Record<string, string>, opts: { migrateAndExit?: boolean
126126
// `childEnv`, not a bare `...process.env`: the vitest worker
127127
// exports `TEST=true`, and better-auth 1.7.1 reads it directly
128128
// to switch its own origin/CSRF validation OFF in the child —
129-
// see `helpers/serve-process.ts` for the measurement (#11267).
129+
// see `helpers/serve-process.ts` for the measurement (commit 1ddda1d00).
130130
// This boot exits at `kernel:ready` (`OS_MIGRATE_AND_EXIT`) and
131131
// never answers a request, so nothing here CHANGES; it is the
132132
// hygiene half, so the next assertion added to this file starts

‎packages/cli/test/build-json-advisory-parity.e2e.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
* #11727 — `os build --json` dropped the #3366 capability-provider hints and
55
* the ADR-0046 package-docs advisories that `os validate --json` carries.
66
*
7-
* The fourth measured instance of one class in these two files (#10953,
8-
* #11174, #11643, this): an advisory computed and then formatted *inside* an
7+
* The fourth measured instance of one class in these two files (commit be7262e72,
8+
* commit ab23c67ab, #11643, this): an advisory computed and then formatted *inside* an
99
* `if (... && !flags.json)` print block, which puts it structurally out of
1010
* reach of the payload — computed, then discarded, for the one audience
1111
* `--json` exists to serve. Measured at `origin/main` 589758d22 over the

‎packages/cli/test/build-json-failure-conversions.e2e.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* to appear exactly ONCE — the payload now carries the notice, and the terminal
1616
* gains no second stderr line for it.
1717
*
18-
* #12125 — `os build --json`'s FAILURE payloads dropped the `conversions` field
18+
* The defect commit 79cf692b0 fixed — `os build --json`'s FAILURE payloads dropped the `conversions` field
1919
* the run had ALREADY COMPUTED, on all nine of its failure exits.
2020
*
2121
* The same "computed, then dropped on a failure exit" shape as the `warnings`
@@ -523,7 +523,7 @@ describe('#12125 — the contract is exhaustive over `compile.ts`, not just over
523523
// The one integer left, and it rots only in the direction that has to be
524524
// reviewed anyway: exits being REMOVED. Ten is the population the ruling in
525525
// this file's header was made over — nine failure exits plus the terminal
526-
// success payload, the count `#12285` pinned on the day it landed — not a
526+
// success payload, the count commit 79cf692b0 pinned on the day it landed — not a
527527
// count of today. (Today is eleven: the tenth FAILURE exit is ADR-0130 D4's
528528
// per-package author-time rule leg, #14439, a multi-package artifact
529529
// running the same rule table once per package. It arrived after the ruling

‎packages/cli/test/build-warning-truncation-notice.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* notice is indistinguishable from a complete one, so an author who reads it
1616
* and sees their file is clean has read a list that stopped early. Same shape
1717
* as the dropped summary rows pinned in `print-metadata-stats-zero-row.test.ts`
18-
* (#10504, #10952): output that cannot distinguish "none" from "not shown".
18+
* (commits ff5733e03, 0d4bd93e7): output that cannot distinguish "none" from "not shown".
1919
*
2020
* WHAT THESE PINS ASSERT — the pair, not the cap. A test that only checked
2121
* "50 entries printed" passes on the silent tree and pins nothing. So the

‎packages/cli/test/commands.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ describe('os explain — schema catalog accuracy', () => {
132132
// The catalog's element shape, stated locally: `SchemaInfo` is not exported,
133133
// and these tests must stay honest even where `SCHEMAS` widens to `any`.
134134
// ⚠️ The reason recorded here has CHANGED and the discipline has not. This
135-
// file no longer sits outside every tsc program: #14710 landed
135+
// file no longer sits outside every tsc program: commit 95fdf627b landed
136136
// `packages/cli/tsconfig.test.json`, whose `include: ["test/**/*"]` puts this
137137
// file in the program (`tsc --noEmit --listFiles -p tsconfig.test.json`
138138
// resolves it), and it carries NO row in `test-typecheck-debt.json` — so any
@@ -178,7 +178,7 @@ describe('os explain — schema catalog accuracy', () => {
178178
});
179179
});
180180

181-
// ── `os explain` — the WHOLE catalog, swept against the spec (#14811) ──────
181+
// ── `os explain` — the WHOLE catalog, swept against the spec (commit 8ad872ba3) ──
182182
//
183183
// #14782 pinned one entry (`flow`) by parsing its `example` against the real
184184
// schema. This generalises that technique to every entry, and derives the entry

‎packages/cli/test/create-plugin-docs-parity.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license.
22

33
/**
4-
* The `plugin` template's SHAPE against what the docs promise (#14824).
4+
* The `plugin` template's SHAPE against what the docs promise (commit cf6b67164).
55
*
66
* ## Why this pin exists
77
*
@@ -14,7 +14,7 @@
1414
* govern at all (it emits no `objectstack.config.ts`). So the docs were the
1515
* only statement of its shape, and nothing held them to it.
1616
*
17-
* The maintainer's ruling on #14824 is that a documented developer-facing
17+
* The maintainer's ruling that commit cf6b67164 landed is that a documented developer-facing
1818
* command must work for the developer who follows the docs. This file is the
1919
* half of that which no install can check: that the listing the developer READS
2020
* is the listing they GET.

‎packages/cli/test/create.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
// Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license.
22

33
/**
4-
* `os create`'s emitted contract — the pin for #14824.
4+
* `os create`'s emitted contract — the pin for commit cf6b67164.
55
*
66
* ## The defect this file used to certify
77
*
8-
* Until #14824 the only assertion here was
8+
* Until commit cf6b67164 the only assertion here was
99
* `expect(packageJson.dependencies['@objectstack/cli']).toBe('workspace:*')` —
1010
* a test that PASSED on the defect, and would have gone red on the fix. Every
1111
* project `os create` emitted declared its `@objectstack/*` dependencies with
@@ -89,7 +89,7 @@ describe('os create: the sweep covers every shipped template', () => {
8989
it('derives its population from the template map', () => {
9090
expect(TEMPLATE_KEYS.length).toBeGreaterThan(0);
9191
// Named so a rename is loud rather than silent. `plugin` is the survivor of
92-
// the two #14824 reported; `example` was retired in #16483.
92+
// the two templates commit cf6b67164 repaired; `example` was retired in #16483.
9393
expect(TEMPLATE_KEYS).toEqual(expect.arrayContaining(['plugin']));
9494
});
9595

@@ -214,7 +214,7 @@ describe.each(TEMPLATE_KEYS)('os create %s --in-repo — the platform-work emiss
214214
*
215215
* ## The defect
216216
*
217-
* #14824 pointed the default emission at a developer outside this monorepo and
217+
* Commit cf6b67164 pointed the default emission at a developer outside this monorepo and
218218
* the name did not move with the audience: `os create plugin my-thing` kept
219219
* writing `"name": "@objectstack/plugin-my-thing"` — a scope its new owner
220220
* cannot publish to — and no `private` flag. ⚠️ Nothing here could see it. The

‎packages/cli/test/docs-cli-enumeration-parity.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
*
1414
* #8965 an earlier under-inclusive drift on this page.
1515
* #16892 ① the scaffolded-scripts sentence said "these" of THREE commands
16-
* and named TWO npm scripts. Under-inclusive from #16330, and
17-
* for all four scaffolders from #16350 / PR #16888.
16+
* and named TWO npm scripts. Under-inclusive from commit 4998efa71, and
17+
* for all four scaffolders from commit 68aee4c99 (PR #16888).
1818
* #16892 ② `os lint` declares ELEVEN flags; the page documented FOUR.
1919
* One of the seven missing was `--include-platform`, which the
2020
* command NAMES IN ITS OWN HINT — so a reader following that

‎packages/cli/test/extract-hook-body.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ describe('extractHookBody', () => {
113113
expect(() => extractHookBody(fn, 'hook bad')).toThrow(/eval/);
114114
});
115115

116-
// ── the `@capabilities` directive, RETIRED (#10917) ─────────────────────
116+
// ── the `@capabilities` directive, RETIRED (commit 7940de5e0) ───────────
117117
//
118118
// Ruled under ADR-0049 enforce-or-remove: the comment-borne override was read
119119
// off `String(fn)`, and every ordinary authoring path (`.ts`, `.js`, `.mjs`,
@@ -171,7 +171,7 @@ describe('extractHookBody', () => {
171171
});
172172

173173
// The #4391 sibling that pinned `crypto.hash` being filtered OUT of an
174-
// explicit `@capabilities` override went with the directive (#10917): with no
174+
// explicit `@capabilities` override went with the directive (commit 7940de5e0): with no
175175
// override branch there is no token list to filter, so the guarantee is now
176176
// structural rather than a case. The inference half of #4391 is still pinned
177177
// by the test above, which is the route `crypto.hash` could still arrive on.

‎packages/cli/test/fixtures/option-b-reader-probe.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ function makeRecorder(rec: Recording) {
201201
name: 'com.objectstack.probe.option-b-recorder',
202202
// No `type`: `PluginSchema` defaults an absent `type` to `standard`, and
203203
// `'service'` is not a member of the declared closed set — `ObjectKernel`
204-
// refused this object already, and since #16721 `LiteKernel.use()` (the
204+
// refused this object already, and since commit 51ae73123 `LiteKernel.use()` (the
205205
// kernel `bootAndRecord` boots) runs the same contract. Nothing here reads
206206
// `.type`; the recorder IS the subsystems, not a typed plugin.
207207
version: '1.0.0',

0 commit comments

Comments
 (0)