You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 24135ab
Browse filesBrowse the repository at this point in the historyBrowse files
fix(skills): retire the four root-devdep rows by unmarking their fences (#7557) (#7568)
The root-manifest bound (#7554) refused four MARKED fences in
skills/objectui/guides/testing.md and carried them as shrink-only debt in
KNOWN_ROOT_DEVDEP_EXAMPLES. A declared row is uncovered debt, not a green:
every run printed "13 of 17 ts fence(s) judged".
Measured first, per the card's two options. check-skill-examples.mjs reads
exactly ONE declaration on a fence -- MARKER, an exact-string match on the
whole line, with no reason field, no install field and no capture group --
and check-doc-snippet-types.mjs's FRAGMENT_MARKER is not read by it at all
(the word appears twice in the file, both times in prose about the docs
gate's opposite opt-OUT design, never in code). The bound itself,
resolvesOnlyThroughRootManifest, is a pure function of the specifier and two
repository-wide maps with no per-block parameter to declare into. So there is
no form in which a fence keeps its mark and names its install, and even the
docs gate's fragment form routes a block AWAY from the compiled set -- the
same coverage loss as the row, under a different name. That selects option 2.
- unmark the four fences, reason written beside each: vitest and
@playwright/test are the reader's own installs, not packages this
repository publishes;
- delete all four rows, leaving KNOWN_ROOT_DEVDEP_EXAMPLES empty, with its
docblock recording the measurement and when a NEW row is still right;
- lower MARKED_FLOOR ts 17 -> 13, reason beside the row, in this same PR --
the move #7550's ratchet allows only here.
Not a precedent for unmarking a red fence: these four were type-checked by
nothing at all for the whole of their life as rows.
Before: Root bound 4 refused, 4 rows declared; Semantic phase 13 of 17.
After: Root bound refuses nothing; Semantic phase 13 of 13; Marked 13 ts
(floor 13), 39 json (floor 39).
Claude-Session: https://claude.ai/code/session_019RfFHiRCSs3JXLK4cwcfox
Co-authored-by: Claude <noreply@anthropic.com>
<!--Not opted into the example gate: `vitest` is a test runner the reader installs in their own project, not a package this repository publishes, so there is nothing here to type-check this block against.-->
<!--Not opted into the example gate: `vitest` is a test runner the reader installs in their own project, not a package this repository publishes, so there is nothing here to type-check this block against.-->
<!--Not opted into the example gate: `vitest` is a test runner the reader installs in their own project, not a package this repository publishes, so there is nothing here to type-check this block against.-->
<!--Not opted into the example gate: `@playwright/test` is a test runner the reader installs in their own project, not a package this repository publishes, so there is nothing here to type-check this block against.-->
0 commit comments