Repository navigation
Commit 24845c4
fix(types,components,docs): correct the texts objectui#6771 left false about
Fixes #8284
Clause-②: no
The closing dispatch of ruling `5861449497` (batch #229 item 5: Q1 A, Q2
A, Q3 A). objectui#6771 retired `body` as a child-list spelling, so
`children` is the one child-list key and `BaseSchema` refuses `body` by
name. This PR corrects the texts that still described the two-channel
world, including the five texts the claim amendment `5862012296` added
in round 2. It changes **prose and strings only**: no key, value,
refusal behaviour, issue code or path, declared type or rendered result
moves.
Written by the `os-dev` agent dispatched by the `domain:ui` seat #1,
session `https://claude.ai/code/session_01DuWo5bdP9SdVebamn99GGk`.
## What changed, sentence by sentence
Every new sentence was checked against `main` plus this diff. The
measurement that makes it true is in the last column.
| where | old | new | measured |
|:--|:--|:--|:--|
| `zod/form.zod.ts` (`ToggleSchema`, `FormSchema`) and
`zod/layout.zod.ts` (`BoxSchema`, `TextSpanSchema`, `ContainerSchema`,
`FlexSchema`, `StackSchema`, `GridSchema`, `ScrollAreaSchema`): the
`aliasKeyRefusal('body', 'children', …)` detail | "`body` is inherited
from `BaseSchema`, so an authored `body` parsed green here and rendered
an EMPTY element — no error, no warning. objectui#8284." | "`body` is
the child-list spelling objectui#6771 retired — one concept, one
spelling — so it is refused here by name; write the content under
`children`, the one child-list key. objectui#8284." | Re-derived count:
9 (2 in `form.zod.ts`, 7 in `layout.zod.ts`); old text 9 → 0 and new
text 0 → 9 on disk. Built dist: old 0, new 18 (the three published zod
modules). A probe of the built `dist/zod/index.zod.js` shows each of the
nine refuses `body` at path `body` with `invalid_type` and accepts
`children`. The first sentence of each message ("X reads `children`,
never `body`") was left alone: each renderer's only read is of
`schema.children`. |
| `zod/data-display.zod.ts` (`AlertSchema`, `BadgeSchema`): the
`aliasKeyRefusal('body', 'children', …)` detail (round 2) | "… until
objectui#6771 retired the spelling; an authored `body` now parses green
through `.passthrough()` and renders an EMPTY element — no error, no
warning. objectui#8284." | "… until objectui#6771 retired the spelling —
one concept, one spelling — so it is refused here by name; write the
content under `children`, the one child-list key. objectui#8284." The
history clause ("`body` was this node's only child-list key until …") is
kept. | Old 2 → 0 and new 0 → 2 on disk. Built dist: old 0, new 4. The
built zod refuses `body` on both at path `body` with `invalid_type`,
accepts `children`, and the message equals the `.describe()` metadata.
At the 17.6.0 release commit `59f61cfb8` both renderers drew
`schema.body`, which makes the kept clause true. |
| `.changeset/8284-content-channel-per-component.md` | "`BaseSchema`
declares two optional content channels …" and the `alert` / `badge` /
`tooltip` row ("now refused: the other channel") | Kept as written. A
dated note in the objectui#10533 form, dated 2026-09-28, placed after
the table: at release `BaseSchema` declares one content channel, all
twelve components refuse `body`, and `alert` / `badge` / `tooltip`
accept `children`. It also says the Migration paragraph does not hold
for those three and points at objectui#6771's entry. | Frontmatter md5
identical base → head; the diff adds 13 lines and deletes none. The
three renderers' read is `renderChildren(schema.body)` at the 17.6.0
release commit `59f61cfb8` and `renderChildren(schema.children)` on
`main`. The 8284 test's `ROWS` carries `dead: 'body'` for all twelve,
and it passes. |
| `.changeset/6877-div-guidance-names-box.md` (round 2) | "state the
`body` → `children` move that every option except `card` requires" |
Kept. Dated note, 2026-09-28: every option, and `div` itself, reads
`children` only; the move is required with `card` included; a retype no
longer drops `body` content because `div` does not draw it and
validation refuses the key by name; the notice's `body` bullet now says
that (objectui#8284); `deprecated.replacement` is unchanged. | The
runtime probe in the `div.tsx` notice row shows `div` and all six
replacements draw `children` and none draws `body`.
`deprecated.replacement` is byte-identical to the 6877 commit
`4562ea517`. This entry does publish: the release branch's
`packages/components/CHANGELOG.md` carries its opening sentence. |
| `.changeset/6773-aspect-ratio-demo-content.md` (round 2) |
"`aspect-ratio.tsx` reads `ratio`, `className`, `image` (with `alt`) and
`children \|\| body`" | Kept. Dated note, 2026-09-28: since this change
objectui#6771 dropped the `body` arm, in `aspect-ratio.tsx` and in the
nested `card` alike; both zod mirrors refuse `body` by name and both
TypeScript faces declare it `never`; the four card demos already author
`children`. | `aspect-ratio.tsx` reads `schema.ratio`, `className`,
`image`, `alt` and `children`, with no `schema.body`. `card.tsx` has no
`schema.body`. `AspectRatioSchema` and `CardSchema` declare `body?:
never`, and their zod arms are `aliasKeyRefusal`. The four card demos
author `children` at both levels, and the photo demo authors `image`
plus `alt`. |
| `.changeset/6788-context-menu-demo-content.md` (round 2) | "`card.tsx`
reads … `children \|\| body` …" and "`card.tsx` accepts both, but `body`
is marked legacy on `BaseSchema` and objectui#6771 is retiring it" |
Kept. Dated note, 2026-09-28: that read is now `children` alone;
`CardSchema` declares `body` as `never` and its zod mirror refuses it by
name; `BaseSchema.body` is `never`, not a legacy member; the demo's
`children` is the one spelling that renders. | `card.tsx` reads `title`,
`description`, `header`, `children`, `footer`, `clickable` and
`hoverable`, with no `schema.body`. The `basic-context-menu` demo's card
authors `children` and carries no `body`. |
| `content-channel-per-component-8284.test.ts` header | "`BaseSchema`
declares TWO optional content channels …"; "This card rewrote that
docblock"; "Families C (reads both — a live `children \|\| body`
fallback), D … and E … are named on the card with the measurement each
still needs"; "Nothing about rendering changes …" | The first is now in
the past tense, with a paragraph saying what #6771 changed and what the
file still pins. The docblock rewrite is credited to objectui#6771. C is
done by #6771, D is pinned by `content-channel-family-d-9256.test.ts`,
and E is done or superseded (ruling `5861449497`). The not-pinned
section describes the two faces this file reads. | The test code is
byte-identical: md5 from the first `import` to EOF matches base. The
controls the header cites still fire: `span.tsx` raw 1 /
comment-stripped 0, `schema.bodyExtra` in `action-icon.tsx` 1 / 1,
`box.tsx` 0 / 0. Two registrations claim `sidebar`, and the second is
typed `React.FC` of `any`. |
| `card.tsx` JSX comment | "`\|\|` here is ALIAS RESOLUTION — `body` is
the legacy spelling of `children` … the alias order is unchanged." | The
one child-list key is `children`, and objectui#6771 dropped the `body`
fallback arm. No `\|\|` is the guard. `renderNodeSlot` is the guard
(objectui#9162), so an empty slot, `0` included, renders no
`CardContent`. | The only read is `renderNodeSlot(schema.children, …)`.
`isEmptyNodeSlot(0)` is true. The comment avoids the literal chain
spelling because `node-slot-numeric-falsy.test.tsx` pins the source
against it; the first draft quoted it and that pin went red, so this was
caught locally. |
| `div.tsx` `DIV_DEPRECATION_NOTICE`, third bullet | "every replacement
above except "card" reads `children` only, so a blind retype drops it
silently at an unchanged element count." | "`body` is the child-list
spelling objectui#6771 retired, so validation refuses it by name, and
neither this component nor any replacement above draws it." | Runtime
probe through the real `SchemaRenderer` (temporary, uncommitted): `div`,
`box`, `card`, `flex`, `container`, `stack` and `grid` each draw an
authored `children` (the control fires) and none draws `body`; 7/7. The
zod probe shows `DivSchema` refuses `body` by name through `BaseSchema`.
The bullet names no type in double quotes, so the offered set that
`deprecation-guidance-agreement` and `div-guidance-names-box` compare is
unchanged. |
| `div.tsx` docblock above the notice | (appended) | A dated clause: the
"four of those five" reading was the #6877-era measurement, and since
#6771 `card` and `div` read `children` only too. | Same probe. The
docblock says the notice and `div.mdx` move in one stroke, which is why
the next two rows are here. |
| `div.mdx` callout | "every replacement listed above except card reads
children only, so a blind retype drops that content silently" | Mirrors
the notice: objectui#6771 retired that spelling, so validation refuses
it by name, and neither `div` nor any replacement draws it. | Same
probe. The callout is outside the list of code tags that
`div-guidance-names-box` reads, so the offered set is unchanged. |
| `div.mdx` Migration caveat | "Such a node must move that content into
`children` as part of the swap, or it disappears from the page …" |
`div` itself reads `children` too. Until the content moves, validation
refuses the key and the content is missing under `div` and every
replacement alike. | Same probe. |
| `div.mdx` interface block | `body?: SchemaNode[]; // Alternative
content prop` | Removed. `children` is annotated as the child key this
component reads (the `span.mdx` wording). | `DivRenderer` reads only
`schema.children`, and its registration's `inputs` is `className` plus a
`children` slot. |
| `page.mdx` interface block | `body?: … // Main content — one node or a
list` / `children?: … // Alternative content prop` | `children?:
SchemaNode \| SchemaNode[]; // Main content — one node or a list` | The
block documents `type: 'page'`. All five `components-layout-page`
catalog examples have `type` `page` and author `children` (0 `body`).
`PageRenderer` reads only `schema.children`, and the `pageMeta` input is
`children`. `PageNodeSchema.children` is one node or a list on both
faces. The four `page:*` renderers that still draw `body` for stored
documents are separate `@object-ui/components` registrations under the
`page` namespace (in `renderers/layout/containers.tsx`); this page does
not document them and nothing here touches them. |
| new `.changeset/8284-refusal-and-notice-text.md` | — | `patch` for
`@object-ui/types` (the published refusal messages, including `alert`
and `badge` since round 2) and `@object-ui/components` (the runtime
notice). | `check-changeset-presence`: "6 source file(s) of 2 released
package(s) changed, and this change declares 1 changeset(s)". |
body (objectui#8284) (#10879)1 parent e2b3826 commit 24845c4
13 files changed
Lines changed: 142 additions & 68 deletions
File tree
- .changeset
- content/docs/components
- basic
- layout
- packages
- components/src/renderers
- basic
- layout
- types/src
- __tests__
- zod
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
17 | 24 | | |
18 | 25 | | |
19 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
21 | 28 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
30 | 43 | | |
31 | 44 | | |
32 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
51 | | - | |
52 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
53 | 54 | | |
54 | 55 | | |
55 | 56 | | |
| |||
83 | 84 | | |
84 | 85 | | |
85 | 86 | | |
86 | | - | |
87 | | - | |
| 87 | + | |
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | | - | |
| 28 | + | |
30 | 29 | | |
31 | 30 | | |
32 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
84 | 87 | | |
85 | 88 | | |
86 | 89 | | |
| |||
116 | 119 | | |
117 | 120 | | |
118 | 121 | | |
119 | | - | |
| 122 | + | |
120 | 123 | | |
121 | 124 | | |
122 | 125 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
72 | 75 | | |
73 | 76 | | |
74 | 77 | | |
| |||
Lines changed: 38 additions & 27 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | | - | |
12 | | - | |
| 10 | + | |
| 11 | + | |
13 | 12 | | |
14 | | - | |
| 13 | + | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
20 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
27 | 35 | | |
28 | 36 | | |
29 | 37 | | |
30 | 38 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
35 | 43 | | |
36 | 44 | | |
37 | 45 | | |
38 | 46 | | |
39 | | - | |
40 | | - | |
| 47 | + | |
| 48 | + | |
41 | 49 | | |
42 | 50 | | |
43 | 51 | | |
| |||
51 | 59 | | |
52 | 60 | | |
53 | 61 | | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
61 | 73 | | |
62 | 74 | | |
63 | 75 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
68 | 81 | | |
69 | | - | |
70 | | - | |
71 | | - | |
| 82 | + | |
72 | 83 | | |
73 | 84 | | |
74 | 85 | | |
| |||
0 commit comments