Repository navigation
Commit 2f6b2bf
fix(types,plugin-tree): derive TreeViewConfig from the spec and drop titleField (#9052)
`@object-ui/types` published `TreeViewConfig` as a hand-written interface — a
copy of the protocol's `ListView.tree` block under a second name — and the copy
declared a fifth key, `titleField`, that `@objectstack/spec@17.4.0` REFUSES on
that block by name (`TreeConfigSchema` is a `strictObject` since spec #15469
closed the `.passthrough()` window 17.3.0 left open). This repo's published face
therefore accepted what the contract rejects: an author who followed
`@object-ui/types` was refused at publish.
Both divergences are addressed:
- the KEY — `titleField` is removed from the type, and `getTreeConfig`'s
`?? schema.titleField` rung goes with it. That rung read the flattened NODE,
never the block, and `titleField` is declared on neither face; it was also
unreachable from both in-repo producers of an `object-tree` node, each of
which floors `labelField` before the node is built.
- the COPY — `TreeViewConfig` is now `NonNullable<SpecListView['tree']>`, a
derivation rather than a rename of the spec's `TreeConfig`. The NAME is kept
(a consumer census found nine referencing files and no `TreeConfig` free in
the barrel); what is retired is the hand copy behind it, which is the half
that could drift.
The `Pick` interim objectui#8841 offered was conditional on the 17.4.0 bump not
having landed. It had: `chore(deps): take the 17.4.0 @objectstack/* line` moved
the lockfile to 17.4.0 four hours after this card was filed, so the plain alias
is available and no dependency is bumped here.
The three `labelField || titleField` dual-reads (plugin-view, plugin-list,
app-shell) are kept as undeclared tolerant fallbacks so stored view records keep
resolving and objectui#6557's pin stays green; retiring them is a follow-up. The
console's canonical rung stays annotated `TreeViewConfig`; its legacy rung is
deliberately left untyped rather than re-declared.
Both census pins are re-pinned as PARITY WITH THE PROTOCOL rather than as a
literal key list — a literal list is what let this drift through, since it was
maintained alongside the type it was supposed to audit.
Claude-Session: https://claude.ai/code/session_01Jmxdo7bmeqCQHLSfmLVX9w
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>1 parent c3a4273 commit 2f6b2bf
9 files changed
Lines changed: 459 additions & 203 deletions
File tree
- .changeset
- packages
- app-shell/src/views
- plugin-tree
- src
- plugin-view/src
- __tests__
- types/src
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2627 | 2627 | | |
2628 | 2628 | | |
2629 | 2629 | | |
2630 | | - | |
2631 | | - | |
2632 | | - | |
2633 | | - | |
2634 | | - | |
2635 | | - | |
| 2630 | + | |
| 2631 | + | |
| 2632 | + | |
| 2633 | + | |
| 2634 | + | |
| 2635 | + | |
| 2636 | + | |
2636 | 2637 | | |
2637 | 2638 | | |
2638 | 2639 | | |
2639 | 2640 | | |
| 2641 | + | |
| 2642 | + | |
| 2643 | + | |
| 2644 | + | |
| 2645 | + | |
| 2646 | + | |
| 2647 | + | |
| 2648 | + | |
| 2649 | + | |
| 2650 | + | |
| 2651 | + | |
2640 | 2652 | | |
2641 | | - | |
| 2653 | + | |
2642 | 2654 | | |
2643 | 2655 | | |
2644 | 2656 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
81 | | - | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
82 | 93 | | |
83 | 94 | | |
84 | 95 | | |
| |||
98 | 109 | | |
99 | 110 | | |
100 | 111 | | |
101 | | - | |
102 | | - | |
103 | | - | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
104 | 124 | | |
105 | 125 | | |
106 | 126 | | |
| |||
Lines changed: 83 additions & 28 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
29 | 41 | | |
30 | 42 | | |
31 | 43 | | |
| |||
57 | 69 | | |
58 | 70 | | |
59 | 71 | | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
60 | 82 | | |
61 | 83 | | |
62 | 84 | | |
| |||
66 | 88 | | |
67 | 89 | | |
68 | 90 | | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
| 91 | + | |
84 | 92 | | |
85 | 93 | | |
86 | 94 | | |
87 | 95 | | |
88 | 96 | | |
89 | 97 | | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
90 | 118 | | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
97 | 130 | | |
98 | 131 | | |
99 | 132 | | |
100 | 133 | | |
101 | 134 | | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | 135 | | |
110 | 136 | | |
111 | 137 | | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
112 | 167 | | |
113 | 168 | | |
114 | 169 | | |
| |||
0 commit comments