Repository navigation
Commit 75bd83d
* feat(types,plugin-gantt): declare the flattened GanttConfig face ObjectGantt reads (#6051)
`getGanttConfig` has two branches. When `startDateField` and `endDateField` are
both present at the TOP level it builds its config from top-level keys and
returns early; otherwise it reads the `gantt` block. Everything the first branch
reads was undeclared, and unlike #5903's ten none of it was behind a cast:
`BaseSchema` carries `[key: string]: any` and the helper's parameter was
`ObjectGridSchema | any`, so `schema.colorField` type-checked as `any` with no
syntax to grep for. The census is therefore an AST enumeration, not a
compile-and-observe — an index signature absorbs exactly the evidence an
annotation would have produced.
- Re-derived on the post-#5903 tree: 47 top-level keys read, 19 declared, 28
residue. #5903 absorbed NONE of the card's 24; the residue is four larger
because #5903 retyped `ObjectGanttProps.schema` to `ObjectGanttSchema`, which
is correct and is why `staticData`/`filter`/`sort` (declared on
`ObjectGridSchema`) now need declaring here, plus `gantt` itself.
- The 24 flattened members are DERIVED from `GanttConfig`, so the flat spelling
cannot fork from the block spelling; the invariant is pinned in the type
system (every `GanttConfig` key is declared at the node's top level).
- Nine members move out of `plugin-gantt`'s package-private `GanttConfigEx` into
`@object-ui/types`' `GanttConfig` to make that derivation possible. A move, not
new vocabulary: the `gantt` block already honoured all nine.
- `getGanttConfig(schema: ObjectGanttSchema)` — without it the reads would still
land on the index signature.
- The zod mirror gains the same 28 at the same requiredness, spec-modelled ones
from `GanttConfigSchema.shape` by reference, so `zod-mirror-parity` stays at
zero drift and no ledger entry is added.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011SfZeFWrhGLHmfq61xbz4q
* refactor(types): sever the `gantt` block declaration to its own card (#6475)
PM ruling 2026-08-26 on #6051: `gantt` is the one key of the measured 28 whose
declaration would NOT have been additive, and a published CLI's refusal
behaviour gets decided on its own card rather than inside a 27-key declaration
PR. The other 27 are unchanged and land here.
Severed: `gantt?: GanttConfig` on `ObjectGanttSchema` and its
`SpecGanttConfigSchema.extend(GanttConfigExtensionFields)` mirror entry. With no
mirror entry a block rides through `.passthrough()` unvalidated; with one it is
parsed against the spec's `GanttConfigSchema`, which REQUIRES startDateField /
endDateField / titleField — and `ObjectGanttSchema` reaches the CLI's
`validate`/`check` through `AnyComponentSchema`, so a block missing one of the
three would move from "accepted, then warned about at runtime" to "refused at
authoring time".
- The omission is recorded where someone would look for the key: a comment on
the declaration, a comment in the mirror, and the `ObjectGanttProps.schema`
JSDoc. All three name #6475 and say `getGanttConfig` still reads and honours
the block, so none of them can be read as "nothing reads `gantt`".
- Today's behaviour is PINNED rather than left implicit — the test that used to
assert the block face accepts the flat vocabulary now asserts the mirror has
no `gantt` entry and that a block missing the required trio (and even a
wrong-typed block) parses green. The omission is a measured state.
- `GanttConfigExtensionFields` stays: it is still the single source the flat
face is built from, and the one line #6475 would need. Its doc no longer
claims it feeds two faces.
This change is now additive-only end to end: 27 new optional keys, no narrowing.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011SfZeFWrhGLHmfq61xbz4q
---------
Co-authored-by: Claude <noreply@anthropic.com>
1 parent 3777538 commit 75bd83d
5 files changed
Lines changed: 807 additions & 87 deletions
File tree
- .changeset
- packages
- plugin-gantt/src
- types/src
- __tests__
- zod
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
93 | | - | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
94 | 105 | | |
95 | 106 | | |
96 | 107 | | |
| |||
101 | 112 | | |
102 | 113 | | |
103 | 114 | | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | 115 | | |
143 | 116 | | |
144 | 117 | | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | 118 | | |
154 | 119 | | |
155 | 120 | | |
| |||
182 | 147 | | |
183 | 148 | | |
184 | 149 | | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | 150 | | |
217 | 151 | | |
218 | 152 | | |
| |||
289 | 223 | | |
290 | 224 | | |
291 | 225 | | |
292 | | - | |
293 | | - | |
294 | | - | |
295 | | - | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
296 | 234 | | |
297 | 235 | | |
298 | 236 | | |
| |||
363 | 301 | | |
364 | 302 | | |
365 | 303 | | |
366 | | - | |
| 304 | + | |
367 | 305 | | |
368 | 306 | | |
369 | | - | |
| 307 | + | |
370 | 308 | | |
371 | 309 | | |
372 | 310 | | |
| |||
402 | 340 | | |
403 | 341 | | |
404 | 342 | | |
405 | | - | |
| 343 | + | |
406 | 344 | | |
407 | 345 | | |
408 | 346 | | |
| |||
0 commit comments