Repository navigation
Commit b1d035b
committed
docs(plugin-form): the currency-scale report's prose says both validators judge a declared subform column now (objectui#11266)
reportCurrencyColumnScale's docblock and the currencyScale-10783 test header
and one test name said a subform's columns is z.array(z.any()) in the
object-form mirror and in the spec's FormViewSchema, and that the spec does
not judge that path. This PR makes the mirror half false, and
@objectstack/spec 17.6.0 already made the spec half false: both now judge a
declared column with InlineGridColumnSchema.
The reason the render-time report exists is restated truthfully: neither zod
face sees an identity-only { name, scale } column whose child field is a
currency, only defineStack does at publish (objectstack#20927), and nothing
runs either validator between a stored or code-built form view and the
render. Comment and test-name bytes only; the TS printer with removeComments
shows no other change.
Claude-Session: https://claude.ai/code/session_01CPvhwGcirXqBGEdPSb72TZ
Co-authored-by: Claude <noreply@anthropic.com>1 parent ce55b46 commit b1d035b
2 files changed
Lines changed: 22 additions & 11 deletions
File tree
- packages/plugin-form/src
Lines changed: 7 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | | - | |
19 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
| |||
69 | 72 | | |
70 | 73 | | |
71 | 74 | | |
72 | | - | |
| 75 | + | |
73 | 76 | | |
74 | 77 | | |
75 | 78 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
296 | 296 | | |
297 | 297 | | |
298 | 298 | | |
299 | | - | |
300 | | - | |
301 | | - | |
302 | | - | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
303 | 307 | | |
304 | | - | |
305 | | - | |
306 | | - | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
307 | 315 | | |
308 | 316 | | |
309 | 317 | | |
| |||
0 commit comments