Repository navigation
Commit b3ac2d4
refactor(charts): delete the scatter's inert ZAxis declaration (#9815)
Fixes #9681
Clause-②: no
The scatter branch of `packages/plugin-charts/src/AdvancedChartImpl.tsx`
declared a symbol-area envelope — a `ZAxis` element carrying
`type="number" range={[60, 400]}` and **no `dataKey`**. It was inert.
This deletes it, repairs the prose that derived a number from it, and
leaves behind a test that states the painted mark size as a **reading**
rather than as a declaration.
## The fork on the card is not reopened here
The card left one open — delete the declaration, or give it a `dataKey`.
The dispatching seat ruled **DELETE**, by the floor and not by
preference: variable-area marks do not exist in this product today, so
wiring a `dataKey` **adds a capability** and is the maintainer's to
take. ⛔ Nothing here prepares for that arm, and nothing here forecloses
it either — a promise the tree does not keep is removed, that is all.
## Re-derived, not inherited — the declaration really was inert
⭐ This is the entire basis for calling the delete behaviour-neutral, so
it was measured at this head rather than carried over from the card.
**Mechanism** (recharts 3.10.1, `es6/state/selectors/axisSelectors.js` +
`es6/cartesian/Scatter.js`). The declared `range` is bypassed **twice
over**:
1. `selectZAxisWithScale` returns `undefined` unless both the axis
settings **and** a configured scale resolve. With no `dataKey` there is
no domain, so no scale, so the registered axis never leaves the
selector.
2. `computeScatterPoints` then takes `defaultRangeZ = zAxis ?
zAxis.range : implicitZAxis.range`. With `zAxis` undefined it reads
recharts' own `implicitZAxis.range`, which is `[64, 64]` — ⛔ **not** the
declared `[60, 400]`. A point with no z value is painted at that range's
lower bound, as a circle of `sqrt(area / PI)`.
**The discriminating number.** If any part of the declaration had
reached a mark — even only as `defaultRangeZ[0]` — the radius would be
`sqrt(60 / PI)` = **4.370193722368317**. Measured with the declaration
still present, every mark's radius is **4.51351666838205** = `sqrt(64 /
PI)`. The declared envelope contributes nothing.
**Where that measurement comes from.** Rendered through the same
mechanism objectui#7396's edge-clipping suite documents:
`ResponsiveContainer` replaced by an explicit 510x350 box, after which
recharts computes the plot rect and every symbol's geometry
arithmetically, with no DOM measurement in the path. 1 parent 78a0582 commit b3ac2d4
4 files changed
Lines changed: 222 additions & 15 deletions
File tree
- .changeset
- packages/plugin-charts/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
| 109 | + | |
| 110 | + | |
110 | 111 | | |
111 | 112 | | |
112 | 113 | | |
| |||
166 | 167 | | |
167 | 168 | | |
168 | 169 | | |
169 | | - | |
| 170 | + | |
| 171 | + | |
170 | 172 | | |
171 | 173 | | |
172 | 174 | | |
| |||
Lines changed: 161 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | 27 | | |
29 | 28 | | |
30 | 29 | | |
| |||
395 | 394 | | |
396 | 395 | | |
397 | 396 | | |
398 | | - | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
399 | 406 | | |
400 | 407 | | |
401 | | - | |
402 | | - | |
403 | | - | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
404 | 411 | | |
405 | 412 | | |
406 | 413 | | |
| |||
434 | 441 | | |
435 | 442 | | |
436 | 443 | | |
437 | | - | |
438 | | - | |
439 | | - | |
440 | | - | |
441 | | - | |
442 | | - | |
443 | | - | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
444 | 452 | | |
445 | 453 | | |
446 | 454 | | |
| |||
1973 | 1981 | | |
1974 | 1982 | | |
1975 | 1983 | | |
1976 | | - | |
| 1984 | + | |
| 1985 | + | |
| 1986 | + | |
| 1987 | + | |
| 1988 | + | |
| 1989 | + | |
| 1990 | + | |
| 1991 | + | |
| 1992 | + | |
| 1993 | + | |
| 1994 | + | |
| 1995 | + | |
| 1996 | + | |
| 1997 | + | |
| 1998 | + | |
| 1999 | + | |
| 2000 | + | |
1977 | 2001 | | |
1978 | 2002 | | |
1979 | 2003 | | |
| |||
0 commit comments