nvim-cmp does not trigger when using markdown link style

[kikur4ge]

🐛 Describe the bug

Starting with 052235c completion with nvim-cmp no longer works if link.style is set to "markdown". There is no error but completion is not triggered/there is no completion menu available. Completion does work if using blink.cmp or if link.style is set to "wiki".

If the changes to completion/refs.lua are reverted then completion does work with [ as the trigger.

:CmpStatus gives

# ready source names
- path
- luasnip
- obsidian
- obsidian_tags
- obsidian_new

Config

return {
    {
        "obsidian-nvim/obsidian.nvim",
        version = "*",
        dependencies = {
            "nvim-lua/plenary.nvim",
        },
        config = true,
        lazy = true,
        event = {
            "BufReadPre " .. vim.fn.expand "~" .. "/my-vault/*.md"
        },

        opts = {

            legacy_commands = false,
            workspaces = {
                {
                    name = "Notes",
                    path = vim.fn.expand("~") .. "/my_vault/",
                },
            },

            completion = {
                nvim_cmp = true,
            },

            link = {
                style = "markdown",
            },
        },
    },
}

Environment

==============================================================================
obsidian:                                                                   ✅

- ✅ OK neovim >= 0.11 (0.11.6)

[Version] ~
- ✅ OK obsidian.nvim v3.15.11 (052235c1e7b7c2655c3d743b3779f42e7975e2d0)

[Environment] ~
- ✅ OK operating system: Darwin

[Config] ~
- ✅ OK dir: /Users/<user>/my-vault/

[Pickers] ~
- ✅ OK telescope.nvim: 3333a52ff548ba0a68af6d8da1e54f9cd96e9179
- ✅ OK snacks.nvim: ad9ede6a9cddf16cedbd31b8932d6dcdee9b716e

[Completion] ~
- ✅ OK nvim-cmp: da88697d7f45d16852c6b2769dc52387d1ddc45f

[Dependencies] ~
- ✅ OK rg: 15.1.0

[neo451]

[ alone as trigger is no longer supported, 1) obsidian app only use [[ as trigger 2) one [ to trigger ref completion is confusing in so many places like latex math #37 and call outs

I have tested that nvim-cmp works, but welcome to give more feedback since I am not 100% sure you issue.

[kikur4ge]

Hi, sorry I was not clear. With the config given above I cannot trigger completion with nvim-cmp using [[ if link.style = "markdown" since commit 052235c. If link.style = "wiki" or if I use blink.cmp then it works as expected.

On the commit previous to 052235c completion did work.

[neo451]

still can not replicate, one thing before moving on, why your checkhealth says you are on 3.15.11, did you do it to regress or something

and your nvim-cmp config?

also this is really the kind of issue that is hard to debug, and these will eventually be resolved with #757, in which if blink works, nvim-cmp works, and completion should work the same

[kikur4ge]

The specific commit in checkhealth is the first commmit in which autocomplete stops working, which continues to the current v3.16.0 release.

My nvim-cmp config is

return {
    "hrsh7th/nvim-cmp",
    dependencies = {
        "L3MON4D3/LuaSnip",
        "saadparwaiz1/cmp_luasnip",
        "micangl/cmp-vimtex",

        "hrsh7th/cmp-nvim-lsp",
        "hrsh7th/cmp-path",

        -- 'rafamadriz/friendly-snippets',
    },
    config = function()
        local cmp = require("cmp")
        local luasnip = require("luasnip")
        require("luasnip.loaders.from_vscode").lazy_load({ paths = { "~/.config/nvim/custom-snippets" } })
        luasnip.config.setup({})

        cmp.setup({
            snippet = {
                expand = function(args)
                    luasnip.lsp_expand(args.body)
                end,
            },
            completion = {
                completeopt = "menu,menuone,noinsert",
            },
            mapping = cmp.mapping.preset.insert({
                ["<C-n>"] = cmp.mapping.select_next_item(),
                ["<C-p>"] = cmp.mapping.select_prev_item(),
                ["<C-b>"] = cmp.mapping.scroll_docs(-4),
                ["<C-f>"] = cmp.mapping.scroll_docs(4),
                ["<C-Space>"] = cmp.mapping.complete({}),
                ["<Tab>"] = cmp.mapping.confirm({
                    behavior = cmp.ConfirmBehavior.Insert,
                    select = true,
                }),
            }),
            sources = {
                { name = "nvim_lsp" },
                { name = "luasnip" },
                { name = "path" },
                { name = "vimtex" },
            },

            performance = {
                max_view_entries = 7,
            },
        })
    end,
}

[neo451]

can you try goto the root of your installed folder for this plugin, edit the minimal.lua to use nvim-cmp and run nvim -u minimal.lua to see whether nvim-cmp works on you machine? It does work for me.

[kikur4ge]

Hi, I have tried this and can confirm it does not work for me. Both nvim-cmp and blink still work with wiki link style, but only blink works with markdown link style. Here is the minimal.lua that does not work

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system "curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua")()

vim.fn.mkdir(".repro/vault", "p")

vim.o.conceallevel = 2

local cwd = vim.uv.cwd()

local plugins = {
  {
    "obsidian-nvim/obsidian.nvim",
    dir = cwd,
    opts = {
      legacy_commands = false,
      workspaces = {
        {
          name = "test",
          path = vim.fs.joinpath(cwd, ".repro", "vault"),
        },
      },

      link = {
        style = "markdown",
      },
    },
  },

  -- **Choose your renderer**
  -- { "MeanderingProgrammer/render-markdown.nvim", dependencies = { "echasnovski/mini.icons" }, opts = {} },
  -- { "OXY2DEV/markview.nvim", lazy = false },

  -- **Choose your picker**
  -- "nvim-telescope/telescope.nvim",
  -- { "folke/snacks.nvim", opts = { picker = { enabled = true } } },
  -- "ibhagwan/fzf-lua",
  -- "echasnovski/mini.pick",

  -- **Choose your completion engine**
  {
    "hrsh7th/nvim-cmp",
    config = function()
      local cmp = require "cmp"
      cmp.setup {
        mapping = cmp.mapping.preset.insert {
          ["<C-e>"] = cmp.mapping.abort(),
          ["<C-y>"] = cmp.mapping.confirm { select = true },
        },
      }
    end,
  },
  -- {
  --   "saghen/blink.cmp",
  --   opts = {
  --     fuzzy = { implementation = "lua" }, -- no need to build binary
  --   },
  -- },
}

require("lazy.minit").repro { spec = plugins }

vim.cmd "checkhealth obsidian"

[neo451]

should work after #787 thanks for the report, feel free to feedback if it still has issues