Update vendored cmdliner to 2.1.1#14636
Conversation
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
| | Error err -> err::errs,args | ||
| let cline = Cmdliner_def.Cline.add arg_info arg cline in | ||
| let errs, args = | ||
| match Cmdliner_def.Arg_info.alias arg_info name value with |
There was a problem hiding this comment.
| match Cmdliner_def.Arg_info.alias arg_info name value with | |
| if for_completion then errs, args | |
| else match Cmdliner_def.Arg_info.alias arg_info name value with |
We probably don't want to expand these when doing completion.
It doesn't have to be in this PR, but I thought I'd point it out anyway.
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
ElectreAAS
force-pushed
the
push-ypyxsntwwwmk
branch
from
5935221 to
779b86d
Compare
|
What happened to the benchmarks? Do we have tests that show that we can still use abbreviated command names? |
They are having a bad day today. They will resolve themselves soon.
Yes, this is the main change between 2.0 and 2.1. A mechanism to support the old prefixes was added. These are all exercised in the |
We do have some, but only by (I assume) accident:
We may have others depending on typos. If you think they'd be needed with this PR I'll add a few that specifically test for this |
|
@rgrinberg Here are the patches on the newer cmdliner that we will maintain from now on: dbuenzli/cmdliner@master...ElectreAAS:dune-cmdliner:push-rtpovsrrqquv in |
3 participants
Fixes #12515.
This PR pulls in all the changes from cmdliner 2.1.1, see changelog here.
Among these changes, there are new error messages formats, so that's a big diff on that commit.
On top of the released cmdliner, there is a singular patch to keep support for aliases.
This has the non-insignificant bonus of simplifying maintenance of our fork over at https://github.com/ocaml-dune/cmdliner