feat(show): let dune show targets look inside directory targets#14666
Draft
Alizter wants to merge 4 commits into
Draft
feat(show): let dune show targets look inside directory targets#14666Alizter wants to merge 4 commits into
Alizter wants to merge 4 commits into
Conversation
Alizter
force-pushed
the
push-yrwupuxptnmm
branch
from
abfdc49 to
5e31e3d
Compare
2 tasks
Use Load_rules instead of Source_tree to check directory existence. Fixes ocaml#13782 Signed-off-by: Ali Caglayan <alizter@gmail.com>
Extract the shared term-building logic of `dune show targets` and `dune show aliases` into a generic `ls_term_gen` that accepts an extra argument term. This lets descendant commits expose additional flags without duplicating the path/context handling. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Walk the `allowed_subdirs` of the loaded directory and surface those containing build targets in the listing. Add an `-a`/`--all` flag to also include hidden directories (those starting with `.`). Fixes ocaml#13783 Signed-off-by: Ali Caglayan <alizter@gmail.com>
Introduce `Build_system.targets_of` to resolve the targets at a given build directory, including paths underneath directory targets. The listing uses validated targets so users can inspect the contents of directory targets directly. Fixes ocaml#13780 Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-yrwupuxptnmm
branch
from
5e31e3d to
0884ab9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
Build_system.targets_ofto resolve the targets at a given build directory, including paths underneath directory targets. The listing uses validated targets so users can inspect the contents of directory targets directly.Stacked on #14665.