fix: clearer error when %{target} is used without a (target ...) field#14668
Open
Alizter wants to merge 2 commits into
Open
fix: clearer error when %{target} is used without a (target ...) field#14668Alizter wants to merge 2 commits into
Alizter wants to merge 2 commits into
Conversation
Captures the current confusing 'You cannot use %{target} with inferred rules'
message that fires when a rule references %{target} but omits the (target ...)
field. The test asserts the situation should produce a clear error pointing
at the missing field. See ocaml#12439.
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-ysursvuvxnvv
branch
from
a8b6711 to
4615d86
Compare
Point the user at the missing field instead of mentioning 'inferred rules'. Fixes ocaml#12439. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-ysursvuvxnvv
branch
from
4615d86 to
e5e2f06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewords the error raised when
%{target}is used in a rule that has no(target ...)field, so it points at the missing field instead of mentioning "inferred rules".