Move build run ids into dune_engine#14673
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
rgrinberg
force-pushed
the
push-wwyowoynlyrn
branch
2 times, most recently
from
314256d to
41b1347
Compare
Move Run_id out of dune_scheduler and allocate watch build run ids in the engine build loop. Pass the current run id into Build_system.run so build start, restart, finish, and allocation trace events remain consistently tagged without the scheduler owning run-id state. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-wwyowoynlyrn
branch
from
41b1347 to
c11563c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Run_id out of dune_scheduler and allocate watch build run ids in the engine build loop. Pass the current run id into Build_system.run so build start, restart, finish, and allocation trace events remain consistently tagged without the scheduler owning run-id state.