Fix Windows watcher sync handling#14678
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
The Windows watcher was the only backend that did not create the sync directory during setup, so emit_sync could fail when the directory was missing. It also consumed sync events directly from the watcher thread. Other backends defer that work to the scheduler thread because the sync table is maintained there; doing the same on Windows avoids racing with emit_sync and keeps the table single-threaded. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows watcher was the only backend that did not create the sync directory during setup, so emit_sync could fail when the directory was missing.
It also consumed sync events directly from the watcher thread. Other backends defer that work to the scheduler thread because the sync table is maintained there; doing the same on Windows avoids racing with emit_sync and keeps the table single-threaded.