Skip to content

Fix Windows watcher sync handling #14678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgrinberg merged 1 commit into from
May 24, 2026
+5 −3
Merged

Fix Windows watcher sync handling #14678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/dune_scheduler/file_watcher.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,9 +585,10 @@ let fswatch_win_callback ~(scheduler : Scheduler.t) ~sync_table ~should_exclude
then (
match Fswatch_win.Event.action event with
| Added | Modified ->
(match Fs_sync.consume_event sync_table filename with
| None -> ()
| Some id -> scheduler.thread_safe_send_emit_events_job (fun () -> [ Sync id ]))
scheduler.thread_safe_send_emit_events_job (fun () ->
match Fs_sync.consume_event sync_table filename with
| None -> []
| Some id -> [ Sync id ])
| Removed | Renamed_new | Renamed_old -> ())
| path ->
let normalized_filename =
Expand All @@ -609,6 +610,7 @@ let fswatch_win_callback ~(scheduler : Scheduler.t) ~sync_table ~should_exclude

let create_fswatch_win ~(scheduler : Scheduler.t) ~debounce_interval:sleep ~should_exclude
=
prepare_sync ();
let sync_table = Table.create (module String) 64 in
let t = Fswatch_win.create () in
Fswatch_win.add t (Path.to_absolute_filename Path.root);
Expand Down
Loading