From f0e00ca2f7f52ad7e9fe875222eb22c6cf6f1093 Mon Sep 17 00:00:00 2001 From: Jon Ludlam Date: Tue, 5 May 2026 10:08:31 +0100 Subject: [PATCH 1/2] Remove bisect_ppx from odoc's opam file bisect_ppx is not needed for any actual tests, and is a slightly painful dependency to have. The GHA that calculates coverage already had an `opam install bisect_ppx`, so shouldn't be affected. --- odoc.opam | 1 - 1 file changed, 1 deletion(-) diff --git a/odoc.opam b/odoc.opam index 4589994626..d40741f8de 100644 --- a/odoc.opam +++ b/odoc.opam @@ -55,7 +55,6 @@ depends: [ "conf-jq" {with-test} "ppx_expect" {with-test} "bos" {with-test} - "bisect_ppx" {with-test & > "2.5.0"} ] conflicts: [ "ocaml-option-bytecode-only" ] From 4634a861f98b9b4bfc5cf79b7ec1faf7847a7173 Mon Sep 17 00:00:00 2001 From: Jon Ludlam Date: Tue, 5 May 2026 12:34:49 +0100 Subject: [PATCH 2/2] Correct argument name in sherlodoc test Older versions of cmdliner silently accepted this as what was there was a prefix of the correct argument name. Newer versions of cmdliner are more strict. --- sherlodoc/test/cram/link_in_docstring.t/run.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sherlodoc/test/cram/link_in_docstring.t/run.t b/sherlodoc/test/cram/link_in_docstring.t/run.t index 365f686593..746ac2a74c 100644 --- a/sherlodoc/test/cram/link_in_docstring.t/run.t +++ b/sherlodoc/test/cram/link_in_docstring.t/run.t @@ -4,9 +4,9 @@ $ export SHERLODOC_DB=db.bin $ export SHERLODOC_FORMAT=marshal $ sherlodoc index $(find . -name '*.odocl') - $ sherlodoc search --print-docstring "foo" + $ sherlodoc search --print-docstring-html "foo" val A.foo : int

This is a docstring with a link

- $ sherlodoc search --print-docstring "bar" + $ sherlodoc search --print-docstring-html "bar" val A.bar : int

This is a docstring with a ref to foo