Shorten --build-config output#2247
Open
vouillon wants to merge 1 commit into
Open
Conversation
vouillon
force-pushed
the
build-info-compact
branch
from
23e9ade to
eba3b3b
Compare
Use a compact encoding for the [--build-config] output: a key at its default is omitted; all other keys still emit [name=value]. Restructure [set_values] to iterate over the known keys rather than the input entries, so that an omitted bool is reset to its default (instead of silently keeping whatever value the caller left it at) and a missing enum is reported as an error. For the typical wasm builds this reduces e.g. effects=jspi+toplevel=false+use-js-string=true (45 chars) to effects=jspi (12 chars), which keeps the build-config directory that dune derives from this output well within Windows' MAX_PATH limit.
vouillon
force-pushed
the
build-info-compact
branch
from
eba3b3b to
985ea75
Compare
Member
|
What about using a more cryptic but compact encoing that would reduce the path size of all configs, event non default ones ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a compact encoding for the
--build-configoutput: a key at its default is omitted; all other keys still emitname=value. Restructureset_valuesto iterate over the known keys rather than the input entries, so that an omitted bool is reset to its default (instead of silently keeping whatever value the caller left it at) and a missing enum is reported as an error.For the typical wasm builds this reduces e.g.
to
which keeps the build-config directory that dune derives from this output well within Windows' MAX_PATH limit.