From d977ea4502f63f155811dc385315aed2bb563c78 Mon Sep 17 00:00:00 2001
From: "Adrien Minne (adrm)" <adrm@odoo.com>
Date: Mon, 1 Jun 2026 13:27:57 +0200
Subject: [PATCH] [IMP] carousel: open chart panel on chart double click

When double clicking in a chart that is inside a carousel, we should
open the chart side panel. Double clicking on the carousel header
should open the carousel side panel.

Task: 6264291
---
 .../figure_carousel/figure_carousel.ts        |  9 ++++++++
 .../figure_carousel/figure_carousel.xml       |  4 +++-
 .../carousel_figure_component.test.ts         | 22 ++++++++++++++++++-
 3 files changed, 33 insertions(+), 2 deletions(-)

diff --git a/src/components/figures/figure_carousel/figure_carousel.ts b/src/components/figures/figure_carousel/figure_carousel.ts
index ea15395970..f5a02ccfee 100644
--- a/src/components/figures/figure_carousel/figure_carousel.ts
+++ b/src/components/figures/figure_carousel/figure_carousel.ts
@@ -85,6 +85,15 @@ export class CarouselFigure extends Component<Props, SpreadsheetChildEnv> {
     this.env.openSidePanel("CarouselPanel", { figureId: this.props.figureUI.id });
   }
 
+  onCarouselChartDoubleClick() {
+    if (this.selectedCarouselItem?.type !== "chart") {
+      return;
+    }
+    const chartId = this.selectedCarouselItem.chartId;
+    this.env.model.dispatch("SELECT_FIGURE", { figureId: this.props.figureUI.id });
+    this.env.openSidePanel("ChartPanel", { chartId });
+  }
+
   isItemSelected(item: CarouselItem): boolean {
     const selectedItem = this.selectedCarouselItem;
     return deepEquals(selectedItem, item);
diff --git a/src/components/figures/figure_carousel/figure_carousel.xml b/src/components/figures/figure_carousel/figure_carousel.xml
index fc18b04553..d9ca35503b 100644
--- a/src/components/figures/figure_carousel/figure_carousel.xml
+++ b/src/components/figures/figure_carousel/figure_carousel.xml
@@ -70,7 +70,9 @@
       <div
         t-elif="selectedItem.type === 'chart'"
         class="o-carousel-content w-100 flex-fill position-relative">
-        <div class="o-chart-container w-100 h-100">
+        <div
+          class="o-chart-container w-100 h-100"
+          t-on-dblclick.stop="this.onCarouselChartDoubleClick">
           <t
             t-component="this.chartComponent"
             chartId="selectedItem.chartId"
diff --git a/tests/figures/carousel/carousel_figure_component.test.ts b/tests/figures/carousel/carousel_figure_component.test.ts
index 02da85b272..c51df37f43 100644
--- a/tests/figures/carousel/carousel_figure_component.test.ts
+++ b/tests/figures/carousel/carousel_figure_component.test.ts
@@ -14,7 +14,13 @@ import {
   selectFigure,
   updateCarousel,
 } from "../../test_helpers/commands_helpers";
-import { click, clickAndDrag, getElStyle, triggerMouseEvent } from "../../test_helpers/dom_helper";
+import {
+  click,
+  clickAndDrag,
+  doubleClick,
+  getElStyle,
+  triggerMouseEvent,
+} from "../../test_helpers/dom_helper";
 import { makeTestEnv, mockChart, mountSpreadsheet, nextTick } from "../../test_helpers/helpers";
 import { extendMockGetBoundingClientRect } from "../../test_helpers/mock_helpers";
 
@@ -328,6 +334,20 @@ describe("Carousel figure component", () => {
     expect(".o-popover .o-menu").toHaveCount(1);
   });
 
+  test("Double Click opens either the carousel or the chart side panel", async () => {
+    createCarousel(model, { items: [] }, "carouselId");
+    const chartId = addNewChartToCarousel(model, "carouselId", { type: "radar" });
+
+    const { fixture, env } = await mountSpreadsheet({ model }, {});
+    const openSidePanel = jest.spyOn(env, "openSidePanel");
+
+    await doubleClick(fixture, ".o-chart-container");
+    expect(openSidePanel).toHaveBeenLastCalledWith("ChartPanel", { chartId });
+
+    await doubleClick(fixture, ".o-carousel-header");
+    expect(openSidePanel).toHaveBeenLastCalledWith("CarouselPanel", { figureId: "carouselId" });
+  });
+
   describe("Carousel menu items", () => {
     let env: SpreadsheetChildEnv;
     let openSidePanel: jest.Mock;