SPECS: ffmpeg: Align librtmp build condition#500
Open
Jingwiw wants to merge 2 commits into
Open
Conversation
Signed-off-by: Jingwiw <wangjingwei@iscas.ac.cn>
Signed-off-by: Jingwiw <wangjingwei@iscas.ac.cn>
openruyi-bot
Bot
added
BuildSystem: autotools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Align the librtmp bcond, BuildRequires, and configure option.
The spec already passes
--enable-librtmpunder%{with librtmp}, but the bcond and BuildRequires were guarded by%{with rtmp}. Use onelibrtmpcondition soall_codecscontrols both dependency selection and the configure option.Source:
configure--enable-librtmp enable RTMP[E] support via librtmp [no]Use
pkgconfig(librtmp)for the librtmp build dependency.FFmpeg checks librtmp through pkg-config, so the BuildRequires should name that provider interface instead of the downstream devel package name.
Source:
configureenabled librtmp && require_pkg_config librtmp librtmp librtmp/rtmp.h RTMP_SocketAIGC Declaration: CodeX with gpt5.5 was used as coding agent.
Signed-off-by: Jingwiw wangjingwei@iscas.ac.cn