SPECS: openssh: Align optional build dependencies#505
Open
Jingwiw wants to merge 4 commits into
Open
Conversation
Signed-off-by: Jingwiw <wangjingwei@iscas.ac.cn>
Signed-off-by: Jingwiw <wangjingwei@iscas.ac.cn>
Signed-off-by: Jingwiw <wangjingwei@iscas.ac.cn>
Signed-off-by: Jingwiw <wangjingwei@iscas.ac.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Drop the unused
--with-systemdconfigure option and the unusedpkgconfig(systemd)build dependency.OpenSSH 10.3p1 enables systemd notification on Linux directly and implements it without linking libsystemd.
Source:
configure.acSource:
openbsd-compat/port-linux.cThe package still keeps
systemd-rpm-macros, because the spec installs systemd units and uses systemd scriptlet macros.Make the FIDO2 builtin support follow the existing
%bcond fido2.Upstream has a dedicated switch for builtin U2F/FIDO support, and the builtin path probes libfido2.
Source:
configure.acSource:
configure.acif test "x$enable_sk" = "xyes" -a "x$enable_sk_internal" != "xno" ; then ... if "$PKGCONFIG" libfido2; then ... fi ... AC_CHECK_HEADER([fido.h], [], [ fido2_error="missing fido.h from libfido2" ])Fix the Kerberos BuildRequires guard to use the actual
%bcond kerberos5.Keep Linux audit BuildRequires scoped to the SELinux build path that enables it.
The spec only passes
--with-audit=linuxinside%if %{with selinux}, so the audit build dependency belongs under the same guard.Source:
configure.acDrop
Requires: pkgconfig(audit)because pkgconfig dependencies are development interfaces, not runtime package requirements.Use
%autochangelogdirectly, matching the current spec style.AIGC Declaration: CodeX with gpt5.5 was used as coding agent.
Signed-off-by: Jingwiw wangjingwei@iscas.ac.cn