Skip to content

SPECS: pinentry: Align GNOME build condition#506

Open
Jingwiw wants to merge 2 commits into
openRuyi-Project:mainfrom
Jingwiw:cleanup-bcond/pinentry-gnome3-option
Open

SPECS: pinentry: Align GNOME build condition#506
Jingwiw wants to merge 2 commits into
openRuyi-Project:mainfrom
Jingwiw:cleanup-bcond/pinentry-gnome3-option

Conversation

@Jingwiw
Copy link
Copy Markdown
Member

@Jingwiw Jingwiw commented May 23, 2026

Changes

  • Add the missing remote asset checksum, drop the unused signature source, and keep the local wrapper as Source1.

  • Make the GNOME3 pinentry configure option follow %bcond gnome.

    The spec defaults %bcond gnome 0, and the pkgconfig(gcr-4) BuildRequires, subpackage, and files are already guarded by %{with gnome}. The old configure flags still always requested --enable-pinentry-gnome3, so a build environment with gcr available could enable GNOME3 support despite the bcond default.

    Source: pinentry-1.3.2/configure.ac:435-480

    AC_ARG_ENABLE(pinentry-gnome3,
                AS_HELP_STRING([--enable-pinentry-gnome3],[build GNOME 3 pinentry]),
                pinentry_gnome_3=$enableval, pinentry_gnome_3=maybe)
    
    if test "$pinentry_gnome_3" != "no"; then
            PKG_CHECK_MODULES(
                    GNOME3,
                    [gcr-4],
                    [
                            pinentry_gnome_3=yes
                    ],
                    [PKG_CHECK_MODULES(
                            GNOME3,
                            [gcr-base-3],
                            [
                                    pinentry_gnome_3=yes
                            ],
                            [
                                    AC_MSG_WARN([pkg-config could not find the module gcr-4 or gcr-base-3])
                                    pinentry_gnome_3=no
                            ]
                    )]
            )
    fi
    
    AM_CONDITIONAL(BUILD_PINENTRY_GNOME_3, test "$pinentry_gnome_3" = "yes")

AIGC Declaration: CodeX with gpt5.5 was used as coding agent.

Signed-off-by: Jingwiw wangjingwei@iscas.ac.cn

Jingwiw added 2 commits May 22, 2026 19:10
Signed-off-by: Jingwiw <wangjingwei@iscas.ac.cn>
Signed-off-by: Jingwiw <wangjingwei@iscas.ac.cn>
@openruyi-bot openruyi-bot Bot added BuildSystem: autotools Issue/PR related to autotools BuildSystem. Target: Rolling Targeting rolling/current branch. Workflow: Ready For Review Ready for review by anyone with domain expertise. labels May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BuildSystem: autotools Issue/PR related to autotools BuildSystem. Target: Rolling Targeting rolling/current branch. Workflow: Ready For Review Ready for review by anyone with domain expertise.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant