Add shellcheck workflow#92
Merged
Merged
Conversation
Collaborator
lkocman
commented
May 17, 2026
lkocman
commented
- Addresses Issue run shellcheck before checking in #86
* Addresses Issue openSUSE#86
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions workflow to run ShellCheck for pull requests, addressing the request to lint the project’s shell code before changes are merged.
Changes:
- Adds a new
ShellCheckworkflow triggered on pull requests. - Installs ShellCheck on
ubuntu-latest. - Runs ShellCheck against
opensuse-migration-tool.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: sudo apt-get update && sudo apt-get install -y shellcheck | ||
|
|
||
| - name: Run ShellCheck | ||
| run: shellcheck opensuse-migration-tool |
| run: sudo apt-get update && sudo apt-get install -y shellcheck | ||
|
|
||
| - name: Run ShellCheck | ||
| run: shellcheck opensuse-migration-tool |
| exceptions=("google-chrome" ) | ||
|
|
||
| while IFS="|" read -r num alias name enabled rest; do | ||
| while IFS="|" read -r _ alias name enabled rest; do |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
Merging the workflow and initial set of fixes |
| exceptions=("google-chrome" ) | ||
|
|
||
| while IFS="|" read -r num alias name enabled rest; do | ||
| while IFS="|" read -r _ alias name enabled rest; do |
| run: sudo apt-get update && sudo apt-get install -y shellcheck | ||
|
|
||
| - name: Run ShellCheck | ||
| run: shellcheck -e SC2086 opensuse-migration-tool scripts/*.sh |
| $DRYRUN echo "Upgrading to ${MIGRATION_OPTIONS[$CHOICE]}" | ||
|
|
||
| SP=$(sed 's/\./-SP/' <<<"$VERSION") # VERSION from /etc/os-release 15.6 -> 15-SP6 | ||
| SP=${VERSION/./-SP} # VERSION from /etc/os-release 15.6 -> 15-SP6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.