From b4141dd3df25ac9240032ddc8b377f2579867760 Mon Sep 17 00:00:00 2001 From: Michael D'Angelo Date: Mon, 3 Aug 2026 17:07:01 -0700 Subject: [PATCH 1/2] fix(cli): render nested scan configuration values as JSON --- sdk/typescript/src/scan-history-renderer.ts | 8 +++++++- .../tests-ts/scan-history-renderer.test.ts | 12 +++++++++++- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/sdk/typescript/src/scan-history-renderer.ts b/sdk/typescript/src/scan-history-renderer.ts index 1c4e79a0..05c60392 100644 --- a/sdk/typescript/src/scan-history-renderer.ts +++ b/sdk/typescript/src/scan-history-renderer.ts @@ -246,7 +246,13 @@ export function renderScanHistory( if (config && Object.keys(config).length > 0) { lines.push( ` ${strong("CONFIGURATION")} ${Object.entries(config) - .map(([key, value]) => `${clean(key)}=${clean(value)}`) + .map(([key, value]) => { + const rendered = + value !== null && typeof value === "object" + ? JSON.stringify(value) + : value; + return `${clean(key)}=${clean(rendered)}`; + }) .join(` ${accent("·")} `)}`, ); } diff --git a/sdk/typescript/tests-ts/scan-history-renderer.test.ts b/sdk/typescript/tests-ts/scan-history-renderer.test.ts index 465209d7..fb7ac43e 100644 --- a/sdk/typescript/tests-ts/scan-history-renderer.test.ts +++ b/sdk/typescript/tests-ts/scan-history-renderer.test.ts @@ -204,7 +204,15 @@ describe("scan history renderer", () => { findingsTruncated: true, artifacts: { markdownReport: "/demo/results/report.md" }, recipe: { - config: { model: "gpt-5.6-sol", model_reasoning_effort: "high" }, + config: { + model: "gpt-5.6-sol", + model_reasoning_effort: "high", + features: { + goals: true, + multi_agent_v2: { enabled: true }, + }, + trusted_paths: ["src", "packages/core"], + }, }, findings: Array.from({ length: 20 }, (_, index) => ({ severity: { level: "high" }, @@ -218,6 +226,8 @@ describe("scan history renderer", () => { "PARENT SCAN 87654321", "CONFIGURATION", "model=gpt-5.6-sol", + 'features={"goals":true,"multi_agent_v2":{"enabled":true}}', + 'trusted_paths=["src","packages/core"]', "COVERAGE", "12 of 15 reviewed", "9 files", From 2d3d4871f32d19f1a96cdbf74b242ce2bf0c986c Mon Sep 17 00:00:00 2001 From: Michael D'Angelo Date: Mon, 3 Aug 2026 17:10:36 -0700 Subject: [PATCH 2/2] refactor(cli): simplify scan configuration rendering --- sdk/typescript/src/scan-history-renderer.ts | 4 +--- sdk/typescript/tests-ts/scan-history-renderer.test.ts | 5 +---- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/sdk/typescript/src/scan-history-renderer.ts b/sdk/typescript/src/scan-history-renderer.ts index 05c60392..f8d2fe6d 100644 --- a/sdk/typescript/src/scan-history-renderer.ts +++ b/sdk/typescript/src/scan-history-renderer.ts @@ -248,9 +248,7 @@ export function renderScanHistory( ` ${strong("CONFIGURATION")} ${Object.entries(config) .map(([key, value]) => { const rendered = - value !== null && typeof value === "object" - ? JSON.stringify(value) - : value; + typeof value === "object" ? JSON.stringify(value) : value; return `${clean(key)}=${clean(rendered)}`; }) .join(` ${accent("·")} `)}`, diff --git a/sdk/typescript/tests-ts/scan-history-renderer.test.ts b/sdk/typescript/tests-ts/scan-history-renderer.test.ts index fb7ac43e..fe0a3e3b 100644 --- a/sdk/typescript/tests-ts/scan-history-renderer.test.ts +++ b/sdk/typescript/tests-ts/scan-history-renderer.test.ts @@ -207,10 +207,7 @@ describe("scan history renderer", () => { config: { model: "gpt-5.6-sol", model_reasoning_effort: "high", - features: { - goals: true, - multi_agent_v2: { enabled: true }, - }, + features: { goals: true, multi_agent_v2: { enabled: true } }, trusted_paths: ["src", "packages/core"], }, },