From 9a6e038798c049cb72e2068f454bb7ee87b2b67b Mon Sep 17 00:00:00 2001 From: philip-morlier Date: Fri, 19 Apr 2024 15:20:21 -0700 Subject: [PATCH] Updated plugin flag parsing to enable loading flags from multiple plugins --- plugins/plugin_loader.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/plugins/plugin_loader.go b/plugins/plugin_loader.go index ccd120f06..3c772fc59 100644 --- a/plugins/plugin_loader.go +++ b/plugins/plugin_loader.go @@ -151,9 +151,13 @@ func RunSubcommand(ctx *cli.Context) (bool, error) { } func (pl *PluginLoader) ParseFlags(args []string) bool { + masterFlagSet := *flag.NewFlagSet("master-plugin-flagset", flag.ContinueOnError) for _, flagset := range pl.Flags { - flagset.Parse(args) + flagset.VisitAll(func(f *flag.Flag) { + masterFlagSet.Var(f.Value, f.Name, f.Usage) + }) } + masterFlagSet.Parse(args) return len(pl.Flags) > 0 }