UpdateGradleWrapper: syntax error near unexpected token

[Pankraz76]

What version of OpenRewrite are you using?

I am using

• OpenRewrite v1.2.3
• Maven/Gradle plugin v1.2.3
• rewrite-module v1.2.3

How are you running OpenRewrite?

I am using the Maven plugin, and my project is a single module project.

<plugin>
  <groupId>org.openrewrite.maven</groupId>
  <artifactId>rewrite-maven-plugin</artifactId>
  <version>1.2.3</version>
  <configuration>
    ... 
  </configuration>
</plugin>

What is the smallest, simplest way to reproduce the problem?

• [openrewrite] Apply GradleBestPractices diffplug/spotless#2708
• Fix: [openrewrite] disable GradleBestPractices to fix build diffplug/spotless#2709

What did you expect to see?

What did you see instead?

➜  spotless git:(fix-rewrite) ./gradlew clean spotlessApply build -x test
./gradlew: line 117: syntax error near unexpected token `('
./gradlew: line 117: `<% if ( classpath ) {%>\'

What is the full stack trace of any errors you encountered?

stacktrace output here

Are you interested in contributing a fix to OpenRewrite?

assuming some kind of dogfood approach could prevent this kind of issues in first place, breaking already on dev or integration instead of production.

[timtebeek]

Hi! What are the actual versions you're using? Because we already made some fixed to the associated scripts that will roll out this coming week:

• Polish GradleWrapperScriptDownloader #6236
• Update rendering logic to ensure 100% match in official Gradle wrapper scripts #6233
• Use virtual threads to download Gradle wrapper scripts #6221
• ffa9575

These issues were discovered whilst dogfooding over the past week, so very much doing what you're proposing already.

I'll close this issue as likely not actionable at this time: the only action left is doing a new release this coming week. Until then you can use our snapshot versions.

[Pankraz76]

nice to see this covered, thanks for the quick support.