[release-4.19] Backport Mellanox firmware reset defaults#1233
Open
SchSeba wants to merge 3 commits into
Open
Conversation
this is needed when the version of mstfwreset will be >= v4.32 Signed-off-by: Sebastian Sch <sebassch@gmail.com>
This feature gate is used to enable the Mellanox firmware reset feature. The reason we enable this feature gate is because on newer mstflint version mstconfig command sends MFRL with bit 6 AND bit 3 ((1<<6)|(1<<3)). some cards like ConnectX-6 Dx firmware does not support the bit 3 (PCIe link toggle) reset trigger for this operation, so the MFRL SET command fails (rc != 0). The code returns "Please power cycle machine to load new configurations." The operator does not have access to out of band management system to make a power cycle. so instead we run mstfwreset command to reset the firmware. Signed-off-by: Sebastian Sch <sebassch@gmail.com> (cherry picked from commit 518df93)
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SchSeba The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Limit the default feature-state backport to feature gates that exist on release-4.19 so the branch builds and the Mellanox reset default remains enabled. Signed-off-by: Sebastian Sch <sebassch@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
SchSeba
force-pushed
the
cp-release-4.19-20260601
branch
from
f0a1e5d to
a1270ed
Compare
Contributor
|
@SchSeba: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kmodin the downstream config daemon image somstfwresetsupport works with newermstflintMellanoxFirmwareResetFeatureGateby default onrelease-4.19release-4.19feature-gate implementation so the new default behavior works with the APIs available on that branchTest plan
go test ./pkg/featuregate ./pkg/plugins/mellanoxrelease-4.19Made with Cursor