chrony: maxsources directive is only respected for pools named "pool"

[lolomokakus]

Package Name

chrony

Maintainer

@mlichvar

OpenWrt Version

25.12.2

OpenWrt Target/Subtarget

mediatek/filogic

Steps to Reproduce

1. Add a pool with any name other than "pool" (including no name)
2. Set a maxsources directive for the pool
3. Commit the changes and restart chronyd

Actual Behaviour

No maxsources directive appears on the pool line in /var/etc/chrony.d/10-uci.conf.

The check on line 48 in chronyd.init should probably test against $sourcetype rather than $cfg?

Confirmation Checklist

• The package is maintained in this repository.
• I understand that issues related to the base OpenWrt repository or LuCI repository will be closed.
• I am reporting an issue for OpenWrt, not an unsupported fork.

[mlichvar]

Thanks for the report. Yes, it looks like that [ "$cfg" = "pool" ] is wrong.

@systemcrash , I think that is your code. Could you please have a look?

[systemcrash]

I believe this was intentional - since this is how the following config_foreach operates:

config_foreach handle_source pool pool

it expects a named section. ( The UI uses named section types, i.e. only one may exist )

Without testing, I imagine this could be relaxed from
[ -n "$maxsources" ] && [ "$cfg" = "pool" ] to [ -n "$maxsources" ].

Does chrony accept multiple 'pools'?

[lolomokakus]

Right. Chrony does accept multiple pools according to chrony.conf(5), in the same way as multiple servers.

Relaxing the check should work, but if multiple pools aren't supported in other places I don't think there's much point.

I only need a single pool for my use case, but I assumed multiple pools were supported, that's why I thought there was a bug here. (I wasn't aware there was LuCI support for Chrony, so I configured everything by hand.) I'm not sure there's much demand for multiple pools, but it might be nice to have support for it at some point.

Feel free to close this.

[mlichvar]

I think multiple pools should be supported, even in LuCI, same as multiple servers.

Without testing, I imagine this could be relaxed from
[ -n "$maxsources" ] && [ "$cfg" = "pool" ] to [ -n "$maxsources" ].

That makes sense to me. Setting maxsources for a non-pool source won't break anything, it will be ignored by chronyd.