From a3cd2e5decbc357762ebd85b227ae746647c25d8 Mon Sep 17 00:00:00 2001
From: Era Dorta <e.dorta@tudelft.nl>
Date: Mon, 12 Feb 2024 12:57:40 +0000
Subject: [PATCH] Fix visualize_keypoints3d_projected method

---
 tools/mview_mperson_topdown_estimator.py       | 8 ++++----
 xrmocap/visualization/visualize_keypoints2d.py | 9 +++++++++
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/tools/mview_mperson_topdown_estimator.py b/tools/mview_mperson_topdown_estimator.py
index d8ad9594..73686f07 100644
--- a/tools/mview_mperson_topdown_estimator.py
+++ b/tools/mview_mperson_topdown_estimator.py
@@ -15,7 +15,7 @@
 from xrprimer.utils.log_utils import setup_logger
 
 from xrmocap.core.estimation.builder import build_estimator
-from xrmocap.core.visualization import visualize_project_keypoints3d
+from xrmocap.visualization import visualize_keypoints3d_projected
 
 # yapf: enable
 
@@ -102,12 +102,12 @@ def main(args):
                 image_list.append(image_np)
             image_array = np.array(image_list)
 
-            visualize_project_keypoints3d(
+            visualize_keypoints3d_projected(
                 keypoints=pred_keypoints3d,
-                cam_param=fisheye_param,
+                camera=fisheye_param,
                 output_path=os.path.join(args.output_dir, 'kps3d',
                                          f'project_view_{view_name}.mp4'),
-                img_arr=image_array.copy(),
+                background_img_list=mview_img_list[idx],
                 overwrite=True)
 
             visualize_smpl_calibration(
diff --git a/xrmocap/visualization/visualize_keypoints2d.py b/xrmocap/visualization/visualize_keypoints2d.py
index cb321d3c..ee1e6d9f 100644
--- a/xrmocap/visualization/visualize_keypoints2d.py
+++ b/xrmocap/visualization/visualize_keypoints2d.py
@@ -2,6 +2,7 @@
 import cv2
 import numpy as np
 import os
+from mmhuman3d.utils.ffmpeg_utils import prepare_output_path
 from tqdm import tqdm
 from typing import List, Union
 from xrprimer.data_structure.keypoints import Keypoints
@@ -189,6 +190,14 @@ def visualize_keypoints2d(
         line_palette = None
         mframe_line_data = None
         mframe_line_mask = None
+
+    prepare_output_path(
+        output_path=output_path,
+        allowed_suffix=['.mp4', 'gif', ''],
+        tag='output video',
+        path_type='auto',
+        overwrite=overwrite)
+
     ret_value = plot_video(
         output_path=output_path,
         overwrite=overwrite,