[FSSDK-12249] review feedback

Author: junaed-optimizely

package-lock.json

@@ -68,6 +68,7 @@
     "eslint-plugin-prettier": "^5.2.1",
     "eslint-plugin-react": "^7.35.0",
     "eslint-plugin-react-hooks": "^4.6.2",
+    "happy-dom": "^20.4.0",
     "husky": "^9.0.0",
     "jest": "^30.0.0",
     "jest-environment-jsdom": "^30.0.0",

package.json

@@ -74,8 +74,10 @@ export function OptimizelyProvider({
       } catch (error) {
         if (!isMounted) return;
         const err = error instanceof Error ? error : new Error(String(error));
-        store.setClientReady(false);
-        store.setError(err);
+        store.setState({
+          isClientReady: false,
+          error: err,
+        });
       }
     };
 

src/provider/OptimizelyProvider.tsx

@@ -37,7 +37,7 @@ const initialState: ProviderState = {
  * The store follows a simple observable pattern:
  * - Hooks subscribe via `subscribe()` and receive state updates
  * - Provider updates state via setter methods
- * - State is immutable - each update creates a new state object
+ * - Listeners are notified on state changes via callbacks
  */
 export class ProviderStateStore {
   private state: ProviderState;
@@ -80,10 +80,7 @@ export class ProviderStateStore {
       return;
     }
 
-    this.state = {
-      ...this.state,
-      isClientReady: ready,
-    };
+    this.state.isClientReady = ready;
     this.notifyListeners();
   }
 
@@ -94,10 +91,7 @@ export class ProviderStateStore {
   setUserContext(ctx: OptimizelyUserContext | null): void {
     // Always update userContext even if same reference -
     // user attributes may have changed
-    this.state = {
-      ...this.state,
-      userContext: ctx,
-    };
+    this.state.userContext = ctx;
     this.notifyListeners();
   }
 
@@ -110,10 +104,7 @@ export class ProviderStateStore {
       return; // No change, skip notification
     }
 
-    this.state = {
-      ...this.state,
-      error,
-    };
+    this.state.error = error;
     this.notifyListeners();
   }
 

src/provider/ProviderStateStore.ts

@@ -22,7 +22,7 @@ import { ProviderStateStore } from './ProviderStateStore';
  * User information passed to the Provider or hooks for user override.
  */
 export interface UserInfo {
-  id: string;
+  id?: string;
   attributes?: UserAttributes;
 }
 
@@ -64,7 +64,7 @@ export interface OptimizelyProviderProps {
  */
 export interface ProviderState {
   /**
-   * Whether the Optimizely client is ready (datafile loaded).
+   * Whether the Optimizely client is ready.
    */
   isClientReady: boolean;
 

src/provider/types.ts

@@ -2,8 +2,7 @@ import { defineConfig } from 'vitest/config';
 
 export default defineConfig({
   test: {
-    globals: true,
-    environment: 'jsdom',
+    environment: 'happy-dom',
     setupFiles: ['./vitest.setup.ts'],
     include: [
       'src/client/**/*.spec.{ts,tsx}',