"Most Played" feature bug

[noisetta]

Found a bug with the most_played feature. After testing extensively, only one track ever appears in the Most Played list at a time, and the frequency counter never increments beyond 1 regardless of how many times a track is played. Deleted the most_played.db and tested fresh — same result. Looks like the play count increment logic and multi-track tracking aren't working correctly in the binary. @Jepl4r, @Tartarus6 Any ideas?

[noisetta]

Additional context — the bug appeared specifically after I used the delete button (trash icon) in the Most Played page to clear the list. Before the delete, the list had multiple tracks with counts up to 5 that had accumulated normally. After clearing it, the counter stopped incrementing and only one track gets registered at a time. The delete action may have corrupted some internal state in hiby_player that controls the counting logic.

[Jepl4r]

Never had this type of bug. Clicked several times the trash icon when I was testing it, and every time the counter increased normally.

One thing I noticed recently is that if you shut off the device completely and then turn it back on, if it starts on the playing screen some times the counter for the displayed song goes up by one even without playing it.

[Tartarus6]

yeah, that's weird. I haven't looked at the most played stuff at all, since I've never used it. So I have no idea.

[noisetta]

Update — the feature is working correctly, not a bug. After thorough testing, can confirm that the play count is strictly completion-based: a track only registers when it plays to the end and naturally transitions to the next one. Manually skipping never counts.

That's why I was seeing inconsistent results during testing — I kept skipping between tracks. Once I let tracks finish naturally the counts incremented correctly and multiple tracks started appearing in the list. Thanks for your patience on this one!