[BUG/UI] Removing Bonus Pilot Gear Slots does not delete excess gear

[msprijatelj]

Description

If a pilot has the Extended Harness reserve and fills all gear slots, if they delete that reserve and then regain it, the gear remains. It's unclear if this is intended behavior.

Steps to reproduce

1. Create a new pilot.
2. Navigate to the Narrative Profile tab.
3. Click the edit button next to "Reserves and Bonuses"
4. Add the "Extended Harness" reserve.
5. Fill all gear slots on the pilot.
6. Delete the "Extended Harness" reserve.
7. Refresh the page.
8. Re-add the "Extended harness" reserve.
9. Observe that the newly-added gear slots are filled with the previous gear before deleting "Extended Harness".

Expected result

Usually, I would expect that the excess gear is removed from the sheet. That said, this may be desirable behavior and thus ignorable? Dev's choice, feel free to mark as "wontfix".

Information

Comp/Con version: 3.0.0
OS: Windows 10 (Desktop)
Browser: Firefox

[jarena3]

massif-press/compcon#2970

[jarena3]

this is intentional but maybe not useful? I could be convinced otherwise: my thinking was the reason you'd be removing and re-adding the EH was because you were messing around with various builds and keeping the data there might save you some clicks over having to re-set it every time

[msprijatelj]

Hm okay I think I’d need to check first what happens when you remove Extended Harness, then one or more pieces of pilot gear. I noticed there’s a “gear queue” effect you have in compcon, so the worst case scenario in my mind is clearing a piece of gear to cause a hidden one to appear instead.

Otherwise I don’t think this is too egregious an issue.

[jarena3]

tracking this in the ticket from here on out