From 3dd63bbab346615d99bfcb242bfc5f2b7b587d4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D7=A0=CF=85=CE=B1=CE=B7=20=D7=A0=CF=85=CE=B1=CE=B7=D1=95?= =?UTF-8?q?=CF=83=CE=B7?= Date: Sat, 15 Aug 2026 23:42:46 -0700 Subject: [PATCH] docs: record go-code-standards progress Four of five repositories restate the conventions and point at the capability. Three verifications pass. 3.5 does not. Ten export_test.go files alias an unexported function, four of them in gohai, which is the repository that wrote the rule into its own CONTRIBUTING. Recorded rather than ticked. Co-Authored-By: Claude Opus 5 (1M context) --- .../changes/specify-go-code-standards/tasks.md | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/openspec/changes/specify-go-code-standards/tasks.md b/openspec/changes/specify-go-code-standards/tasks.md index 5fbb332..01c6bcc 100644 --- a/openspec/changes/specify-go-code-standards/tasks.md +++ b/openspec/changes/specify-go-code-standards/tasks.md @@ -6,18 +6,20 @@ ## 2. Point each repository at the capability -- [ ] 2.1 `gohai` — `CONTRIBUTING.md` keeps its collector-specific conventions -- [ ] 2.2 `nats-client` — `CONTRIBUTING.md` -- [ ] 2.3 `nats-server` — `CONTRIBUTING.md` -- [ ] 2.4 `osapi-orchestrator` — `CONTRIBUTING.md` +- [x] 2.1 `gohai` — `CONTRIBUTING.md` keeps its collector-specific conventions +- [x] 2.2 `nats-client` — `CONTRIBUTING.md` +- [x] 2.3 `nats-server` — `CONTRIBUTING.md` +- [x] 2.4 `osapi-orchestrator` — `CONTRIBUTING.md` - [ ] 2.5 `osapi` — `CLAUDE.md` drops `Code Standards`, and the conventions duplicated into `development.md` and `testing.md` resolve to one source ## 3. Verification -- [ ] 3.1 Confirm no `types.go` contains a function -- [ ] 3.2 Confirm no repository holds a generically named file -- [ ] 3.3 Confirm every test package uses a table-driven suite +- [x] 3.1 Confirm no `types.go` contains a function +- [x] 3.2 Confirm no repository holds a generically named file +- [x] 3.3 Confirm every test package uses a table-driven suite - [ ] 3.4 Confirm no mock is hand-written where an interface is mocked -- [ ] 3.5 Confirm no `export_test.go` exposes an alias to an unexported function +- [ ] 3.5 Confirm no `export_test.go` exposes an alias to an unexported + function. Ten exist — four in `gohai`, which states the rule, and six in + `osapi`. Eleven call sites depend on them - [ ] 3.6 Confirm no shared convention is stated in two places