From edc5f8e7d8cd6a23a3389b904ff7dabc42551be4 Mon Sep 17 00:00:00 2001 From: pcvantol Date: Mon, 7 Sep 2026 08:42:22 +0200 Subject: [PATCH] Remove external-link cue from component cards --- src/engineering_platform/assets/dashboard.js | 8 -------- tests/engineering/dashboard.spec.mjs | 4 ++-- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/engineering_platform/assets/dashboard.js b/src/engineering_platform/assets/dashboard.js index 6c0d660a..4a66a9a3 100644 --- a/src/engineering_platform/assets/dashboard.js +++ b/src/engineering_platform/assets/dashboard.js @@ -3780,14 +3780,6 @@ function renderPlatformHealth(payload) { indicator.setAttribute("aria-hidden", "true"); name.className = "platform-health__component-name"; name.textContent = healthComponentLabel(key); - if (key === "dashboard_relay") { - const linkIcon = document.createElement("span"); - linkIcon.className = "platform-health__component-link-icon"; - linkIcon.dataset.testid = "component-details-link-icon"; - linkIcon.setAttribute("aria-hidden", "true"); - linkIcon.textContent = "↗"; - name.append(linkIcon); - } detail.className = "platform-health__component-detail"; const transportFacts = [ component?.last_successful_submission ? t("transport.last_submission") + " " + component.last_successful_submission : "", diff --git a/tests/engineering/dashboard.spec.mjs b/tests/engineering/dashboard.spec.mjs index fadab436..1c5a01cc 100644 --- a/tests/engineering/dashboard.spec.mjs +++ b/tests/engineering/dashboard.spec.mjs @@ -6748,7 +6748,7 @@ test.describe("Engineering Status browser smoke", () => { await expect(info).toHaveCSS("color", "rgb(163, 230, 53)"); }); - test("marks only Dashboard Relay with its external-link icon", async ({ page }) => { + test("does not imply that a component detail card opens an external link", async ({ page }) => { await page.goto(dashboardUrl, { waitUntil: "domcontentloaded" }); const rendered = await page.evaluate(() => { renderPlatformHealth({ components: { @@ -6760,7 +6760,7 @@ test.describe("Engineering Status browser smoke", () => { return [...document.querySelectorAll(".platform-health__component-name")] .map((name) => Boolean(name.querySelector("[data-testid='component-details-link-icon']"))); }); - expect(rendered).toEqual([false, false, true, false]); + expect(rendered).toEqual([false, false, false, false]); }); test("keeps iPhone platform component cards on opaque, flat surfaces", async ({ page }) => {