From 3f1a1b4868aff1b36f3b69f4d4c429373e28bc05 Mon Sep 17 00:00:00 2001 From: Pedro Filho Date: Fri, 21 Aug 2026 13:04:27 -0300 Subject: [PATCH] chore: remove eslint-disable comments The disables were papering over nextjs/no-img-element firing outside its scope. Docs now uses next/image (unoptimized, SVG logos); demo-vite gets a scoped oxlint override since next/image does not exist in a Vite app; the landing array-index-key disable was dead weight. --- apps/demo-vite/src/root.tsx | 2 -- apps/docs/lib/layout.shared.tsx | 9 +++++---- apps/landing/app/_components/chart-panel.tsx | 7 +------ oxlint.config.ts | 9 +++++++++ 4 files changed, 15 insertions(+), 12 deletions(-) diff --git a/apps/demo-vite/src/root.tsx b/apps/demo-vite/src/root.tsx index b4b1da3..636d135 100644 --- a/apps/demo-vite/src/root.tsx +++ b/apps/demo-vite/src/root.tsx @@ -81,7 +81,6 @@ const RootLayout = (): ReactNode => (
- {/* eslint-disable-next-line @next/next/no-img-element */} dashfoo ( src="/dashfoo-logo-light.svg" width={105} /> - {/* eslint-disable-next-line @next/next/no-img-element */} dashfoo ({ nav: { title: ( <> - {/* eslint-disable-next-line @next/next/no-img-element */} - dashfoo - {/* eslint-disable-next-line @next/next/no-img-element */} - dashfoo diff --git a/apps/landing/app/_components/chart-panel.tsx b/apps/landing/app/_components/chart-panel.tsx index e8208b2..1f9b2c8 100644 --- a/apps/landing/app/_components/chart-panel.tsx +++ b/apps/landing/app/_components/chart-panel.tsx @@ -10,12 +10,7 @@ const ChartPanel = (): ReactNode => (
{CHART_BARS.map((h, i) => ( -
+
))}
diff --git a/oxlint.config.ts b/oxlint.config.ts index 93362d3..d978b4a 100644 --- a/oxlint.config.ts +++ b/oxlint.config.ts @@ -21,6 +21,15 @@ export default defineConfig({ }, }, + { + // demo-vite is a Vite app: next/image does not exist there, so the Next-specific + // img ban cannot be satisfied. + files: ["apps/demo-vite/**/*.tsx"], + rules: { + "nextjs/no-img-element": "off", + }, + }, + { files: ["packages/react/src/hooks/responsive.ts"], rules: {