From 814ca58c72621c97e63712747301563f18465a0f Mon Sep 17 00:00:00 2001
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
Date: Mon, 17 Jun 2024 20:31:55 +0200
Subject: [PATCH] umpf: omit hash/version info on show without --identical

The topic-range and hashinfo information won't be used later on, unless
--identical is given. It thus makes sense to ignore them in umpf show
too, unless the user requests them with --identical.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 tests/meson.build                    |  1 +
 tests/series-identical-v1.ref        | 10 ++++++++++
 tests/series-v1.ref                  |  5 -----
 tests/umpf-merge                     |  2 +-
 tests/umpf-merge-build               |  2 +-
 tests/umpf-series-build              |  2 +-
 tests/umpf-series-tag-continue-flags |  2 +-
 tests/umpf-show-identical            |  8 ++++++++
 umpf                                 |  8 +++++++-
 9 files changed, 30 insertions(+), 10 deletions(-)
 create mode 100644 tests/series-identical-v1.ref
 create mode 100755 tests/umpf-show-identical

diff --git a/tests/meson.build b/tests/meson.build
index e9d802f..0ecd236 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -23,6 +23,7 @@ tests = [
   'umpf-format-patch',
   'umpf-format-patch-bb',
   'umpf-show',
+  'umpf-show-identical',
   'umpf-versions'
 ]
 foreach test_name : tests
diff --git a/tests/series-identical-v1.ref b/tests/series-identical-v1.ref
new file mode 100644
index 0000000..2706fcc
--- /dev/null
+++ b/tests/series-identical-v1.ref
@@ -0,0 +1,10 @@
+# umpf-base: base
+# umpf-name: name
+# umpf-version: name/20221209-1
+# umpf-topic: a
+# umpf-hashinfo: f46ed0419d2c31ed10f978cc461e0d1ae4b3b426
+# umpf-topic-range: d306da785d874c09b89264d3f71632bc14bfe51f..b2b9f854952b0be84ba2472f236783d09bfa6561
+# umpf-topic: b
+# umpf-hashinfo: 3755a03cf640725df1aeb13789cba87154a47b04
+# umpf-topic-range: b2b9f854952b0be84ba2472f236783d09bfa6561..e791a2bb22e021b8513809e1e1cbf692be74fd99
+# umpf-end
diff --git a/tests/series-v1.ref b/tests/series-v1.ref
index 2706fcc..bbf3d73 100644
--- a/tests/series-v1.ref
+++ b/tests/series-v1.ref
@@ -1,10 +1,5 @@
 # umpf-base: base
 # umpf-name: name
-# umpf-version: name/20221209-1
 # umpf-topic: a
-# umpf-hashinfo: f46ed0419d2c31ed10f978cc461e0d1ae4b3b426
-# umpf-topic-range: d306da785d874c09b89264d3f71632bc14bfe51f..b2b9f854952b0be84ba2472f236783d09bfa6561
 # umpf-topic: b
-# umpf-hashinfo: 3755a03cf640725df1aeb13789cba87154a47b04
-# umpf-topic-range: b2b9f854952b0be84ba2472f236783d09bfa6561..e791a2bb22e021b8513809e1e1cbf692be74fd99
 # umpf-end
diff --git a/tests/umpf-merge b/tests/umpf-merge
index 335706f..071889f 100644
--- a/tests/umpf-merge
+++ b/tests/umpf-merge
@@ -6,6 +6,6 @@
 umpf merge a
 umpf merge b
 
-umpf show --base=base --name=name > series.merge
+umpf show --identical --base=base --name=name > series.merge
 
 diff -u ${TEST_DIR}/series-merge.ref series.merge
diff --git a/tests/umpf-merge-build b/tests/umpf-merge-build
index 7ddb630..24dea8d 100644
--- a/tests/umpf-merge-build
+++ b/tests/umpf-merge-build
@@ -6,5 +6,5 @@
 git checkout umpf-merge
 umpf build --remote=origin --base=base --name=name
 
-umpf show > series.build
+umpf show --identical > series.build
 diff -u ${TEST_DIR}/series-merge.ref series.build
diff --git a/tests/umpf-series-build b/tests/umpf-series-build
index fd23331..f742166 100644
--- a/tests/umpf-series-build
+++ b/tests/umpf-series-build
@@ -9,5 +9,5 @@ git ls-tree umpf-build > ls-tree.ref
 git ls-tree HEAD > ls-tree.build
 diff -u ls-tree.ref ls-tree.build
 
-umpf show HEAD > series.build
+umpf show --identical HEAD > series.build
 diff -u ${TEST_DIR}/series-merge.ref series.build
diff --git a/tests/umpf-series-tag-continue-flags b/tests/umpf-series-tag-continue-flags
index 6703348..f71f9e3 100644
--- a/tests/umpf-series-tag-continue-flags
+++ b/tests/umpf-series-tag-continue-flags
@@ -20,7 +20,7 @@ sed -i '/^# umpf-base: base$/a # umpf-flags: extraversion=conflictfree' series.c
 umpf tag -f --version=2 series.conflict --remote=origin || test $? = 1
 git add a.txt
 echo | umpf continue
-umpf show 2>&1
+umpf show --identical 2>&1
 
 diff -u ${TEST_DIR}/version-files/ref/Makefile.conflictfree Makefile
 git log --format=%B -n 1 | grep "^# umpf-" > series.tag
diff --git a/tests/umpf-show-identical b/tests/umpf-show-identical
new file mode 100755
index 0000000..fe3cbef
--- /dev/null
+++ b/tests/umpf-show-identical
@@ -0,0 +1,8 @@
+#!/bin/bash
+#
+# Test the output of "umpf show".
+#
+
+umpf show --identical umpf-tag > series.show
+
+diff -u ${TEST_DIR}/series-identical-v1.ref series.show
diff --git a/umpf b/umpf
index 3892a63..9efd7e7 100755
--- a/umpf
+++ b/umpf
@@ -1877,7 +1877,13 @@ do_abort() {
 
 do_show() {
 	VERBOSE=true
-	prepare_persistent show "${@}"
+	prepare_persistent show "${@}" | (
+		if $IDENTICAL; then
+			cat
+		else
+			sed -r '/^# umpf-(version|topic-range|hashinfo|release): /d'
+		fi
+	)
 	cleanup
 }