Skip to content

Commit be7527a

Browse files
committed
fix: multiple passwords not rendered correctly
1 parent ca9fb93 commit be7527a

3 files changed

Lines changed: 25 additions & 2 deletions

File tree

Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
apiVersion: v1
22
name: pgdog
3-
version: v0.53
3+
version: v0.54
44
appVersion: "0.1.37"

templates/secrets.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
name = {{ .name | quote }}
55
database = {{ .database | quote }}
66
{{- if .passwords }}
7-
passwords = {{ .passwords | toToml }}
7+
passwords = [{{ range $i, $p := .passwords }}{{ if $i }}, {{ end }}{{ $p | quote }}{{ end }}]
88
{{- else if .password }}
99
password = {{ .password | quote }}
1010
{{- end }}

test/test.sh

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,28 @@ for values_file in "$TEST_DIR"/values-*.yaml; do
1414
helm template test-release "$CHART_DIR" -f "$values_file" | kubeconform -strict -ignore-missing-schemas -summary
1515
done
1616

17+
# Validate multiple passwords renders valid TOML
18+
echo ""
19+
echo "==> Validating multiple passwords TOML output..."
20+
users_toml=$(helm template test-release "$CHART_DIR" -f "$TEST_DIR/values-multiple-passwords.yaml" \
21+
| yq -r 'select(.kind == "Secret" and .metadata.name == "test-release-pgdog") | .data["users.toml"]' \
22+
| base64 -d)
23+
24+
if echo "$users_toml" | grep -q 'passwords = \["one", "two"\]'; then
25+
echo " passwords array rendered correctly"
26+
else
27+
echo " FAIL: passwords array not rendered correctly"
28+
echo " Got: $users_toml"
29+
exit 1
30+
fi
31+
32+
if echo "$users_toml" | grep -q 'password = "single_password"'; then
33+
echo " single password rendered correctly"
34+
else
35+
echo " FAIL: single password not rendered correctly"
36+
echo " Got: $users_toml"
37+
exit 1
38+
fi
39+
1740
echo ""
1841
echo "==> All tests passed!"

0 commit comments

Comments
 (0)