From 99ea3824272ecc6a196ab8ea323a96129f5917ad Mon Sep 17 00:00:00 2001 From: "Trevor L. Davis" Date: Wed, 15 Apr 2026 22:23:50 -0700 Subject: [PATCH] fix: Replace deprecated ppdf functions with their replacements Co-Authored-By: Claude Sonnet 4.6 --- NEWS.md | 5 ++++- R/parse_moves.R | 12 ++++++------ 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/NEWS.md b/NEWS.md index d2ea363..4c54997 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,7 +1,10 @@ ppn 0.2.2 (development) ======================= -* No user-facing changes. +Bug fixes and minor improvements +-------------------------------- + +* Eliminated use of deprecated `ppdf` functions. ppn 0.2.1 ========= diff --git a/R/parse_moves.R b/R/parse_moves.R index 88044e3..6ab2b40 100644 --- a/R/parse_moves.R +++ b/R/parse_moves.R @@ -204,12 +204,12 @@ standardize_piece_spec <- function(piece_spec) { if (!is.na(piece <- str_extract(x, character_class(c(unicode_chess_pieces))))) { rank <- ppdf::chess_rank(piece) + 1L if (!str_detect(x, "[RKGBYW]")) { - suit <- ppdf::chess_suit(piece) + suit <- ppdf::piece_suit(piece) } if (!is.na(angle)) { - angle <- (angle + ppdf::chess_angle(piece)) %% 360 + angle <- (angle + ppdf::piece_angle(piece)) %% 360 } else { - angle <- ppdf::chess_angle(piece) + angle <- ppdf::piece_angle(piece) } cfg <- getOption("ppn.default_chess_cfg", "chess2") # Turn into bit @@ -226,12 +226,12 @@ standardize_piece_spec <- function(piece_spec) { } else { x <- gsub(tile, "", x) } - rank <- ppdf::domino_rank(tile) + 1L + rank <- ppdf::piece_rank(tile) + 1L suit <- ppdf::domino_suit(tile) + 1L if (!is.na(angle)) { - angle <- (angle + ppdf::domino_angle(tile)) %% 360 + angle <- (angle + ppdf::piece_angle(tile)) %% 360 } else { - angle <- ppdf::domino_angle(tile) + angle <- ppdf::piece_angle(tile) } if (!is.na(col <- str_extract(x, "[RKGBYW]"))) { x <- gsub(col, "", x)